-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add index benchmark #5508
Merged
Merged
Add index benchmark #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Oct 1, 2024
CodSpeed Performance ReportMerging #5508 will not alter performanceComparing Summary
Benchmarks breakdown
|
kenodegard
commented
Oct 1, 2024
Comment on lines
+1853
to
+1865
if Version(conda_version) >= Version("24.9.0"): | ||
# conda >=24.9.0 | ||
clobber_warning_found = False | ||
for record in caplog.records: | ||
if "ClobberWarning:" in record.message: | ||
clobber_warning_found = True | ||
assert clobber_warning_found | ||
else: | ||
# before the new lazy index added in conda 24.9.0 | ||
# see https://github.com/conda/conda/commit/1984b287548a1a526e8258802a6f1fec2a11ecc3 | ||
out, err = capfd.readouterr() | ||
assert "ClobberWarning" in err | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fix from #5488 that we need to get this merged
beeankha
approved these changes
Oct 1, 2024
jezdez
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a benchmark test so we can see the speed improvements with the new lazy index from
conda 24.9.0
.A few things are done here:
locking
andtimeout
) fromconda_buil.index.get_build_index
conda=24.7
so we can get an accurate before measurement (we will revert this change in Lazy index #5488)tests/test_index.py::test_get_build_index
filterwarings
in pyproject.toml to avoid deprecation errors (we will revert this change in Lazy index #5488)Xref #5488
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update outdated documentation?