Add index benchmark

.github/workflows/tests.yml

@@ -210,7 +210,7 @@ jobs:
  --file tests/requirements-${{ runner.os }}.txt
  --file tests/requirements-ci.txt
  python=${{ matrix.python-version }}
- ${{ env.CONDA_CHANNEL_LABEL }}${{ env.CONDA_VERSION }}
+ conda=24.7
 
  - name: Install CodSpeed
  run: pip install git+https://github.com/kenodegard/pytest-codspeed.git@fix-outerr-redirects#egg=pytest-codspeed

conda_build/build.py

@@ -2797,8 +2797,6 @@ def build(
  channel_urls=m.config.channel_urls,
  debug=m.config.debug,
  verbose=m.config.verbose,
- locking=m.config.locking,
- timeout=m.config.timeout,
  clear_cache=True,
  omit_defaults=False,
  )
@@ -2809,8 +2807,6 @@ def build(
  channel_urls=m.config.channel_urls,
  debug=m.config.debug,
  verbose=m.config.verbose,
- locking=m.config.locking,
- timeout=m.config.timeout,
  clear_cache=True,
  omit_defaults=False,
  )

conda_build/environ.py

@@ -865,8 +865,6 @@ def get_install_actions(
  channel_urls=channel_urls,
  debug=debug,
  verbose=verbose,
- locking=locking,
- timeout=timeout,
  )
  specs = tuple(
  utils.ensure_valid_spec(spec) for spec in specs if not str(spec).endswith("@")
@@ -1038,8 +1036,6 @@ def create_env(
  channel_urls=config.channel_urls,
  debug=config.debug,
  verbose=config.verbose,
- locking=config.locking,
- timeout=config.timeout,
  )
  _display_actions(prefix, precs)
  if utils.on_win:

conda_build/index.py

@@ -12,6 +12,7 @@
 from conda_index.index import update_index as _update_index
 
 from . import utils
+from .deprecations import deprecated
 from .utils import (
  get_logger,
 )
@@ -29,6 +30,8 @@
 # os.environ['CONDA_ADD_ANACONDA_TOKEN'] = "false"
 
 
+@deprecated.argument("24.11", "25.1", "locking")
+@deprecated.argument("24.11", "25.1", "timeout")
 def get_build_index(
  subdir,
  bldpkgs_dir,
@@ -38,8 +41,6 @@ def get_build_index(
  channel_urls=None,
  debug=False,
  verbose=True,
- locking=None,
- timeout=None,
 ):
  """
  Used during package builds to create/get a channel including any local or

conda_build/render.py

@@ -334,8 +334,6 @@ def execute_download_actions(m, precs, env, package_subset=None, require_files=F
  channel_urls=m.config.channel_urls,
  debug=m.config.debug,
  verbose=m.config.verbose,
- locking=m.config.locking,
- timeout=m.config.timeout,
  )
 
  # this should be just downloading packages. We don't need to extract them -

news/5508-deprecate-get_build_index-locking-timeout

@@ -0,0 +1,20 @@
+### Enhancements
+
+* <news item>
+
+### Bug fixes
+
+* <news item>
+
+### Deprecations
+
+* Deprecate `conda_build.index.get_build_index(locking)`. (#5508)
+* Deprecate `conda_build.index.get_build_index(timeout)`. (#5508)
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>

pyproject.toml

@@ -115,20 +115,20 @@ doctest_optionflags = [
  "ALLOW_UNICODE",
  "ELLIPSIS",
 ]
-filterwarnings = [
-  # elevate conda's deprecated warning to an error
-  "error::PendingDeprecationWarning:conda",
-  "error::DeprecationWarning:conda",
-  # elevate conda-build's deprecated warning to an error
-  "error::PendingDeprecationWarning:conda_build",
-  "error::DeprecationWarning:conda_build",
-  # ignore numpy.distutils error
-  'ignore:\s+`numpy.distutils` is deprecated:DeprecationWarning:conda_build._load_setup_py_data',
-  # ignore conda-index error
-  "ignore::PendingDeprecationWarning:conda_index",
-  "ignore::DeprecationWarning:conda_index",
-  "ignore:Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata:DeprecationWarning",
-]
+# filterwarnings = [
+# # elevate conda's deprecated warning to an error
+# "error::PendingDeprecationWarning:conda",
+# "error::DeprecationWarning:conda",
+# # elevate conda-build's deprecated warning to an error
+# "error::PendingDeprecationWarning:conda_build",
+# "error::DeprecationWarning:conda_build",
+# # ignore numpy.distutils error
+# 'ignore:\s+`numpy.distutils` is deprecated:DeprecationWarning:conda_build._load_setup_py_data',
+# # ignore conda-index error
+# "ignore::PendingDeprecationWarning:conda_index",
+# "ignore::DeprecationWarning:conda_index",
+# "ignore:Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata:DeprecationWarning",
+# ]
 markers = [
  "serial: execute test serially (to avoid race conditions)",
  "slow: execute the slow tests if active",

tests/test_api_build.py

@@ -27,11 +27,13 @@
 import yaml
 from binstar_client.commands import remove, show
 from binstar_client.errors import NotFound
+from conda import __version__ as conda_version
 from conda.base.context import context, reset_context
 from conda.common.compat import on_linux, on_mac, on_win
 from conda.exceptions import ClobberError, CondaError, CondaMultiError, LinkError
 from conda.utils import url_path
 from conda_index.api import update_index
+from packaging.version import Version
 
 from conda_build import __version__, api, exceptions
 from conda_build.config import Config
@@ -69,7 +71,7 @@
 )
 
 if TYPE_CHECKING:
- from pytest import FixtureRequest, MonkeyPatch
+ from pytest import CaptureFixture, FixtureRequest, LogCaptureFixture, MonkeyPatch
  from pytest_mock import MockerFixture
 
  from conda_build.metadata import MetaData
@@ -1826,7 +1828,11 @@ def test_downstream_tests(testing_config):
 
 
 @pytest.mark.sanity
-def test_warning_on_file_clobbering(testing_config, capfd):
+def test_warning_on_file_clobbering(
+ testing_config: Config,
+ capfd: CaptureFixture,
+ caplog: LogCaptureFixture,
+) -> None:
  recipe_dir = os.path.join(metadata_dir, "_overlapping_files_warning")
 
  api.build(
@@ -1844,8 +1850,19 @@ def test_warning_on_file_clobbering(testing_config, capfd):
  config=testing_config,
  )
  # The clobber warning here is raised when creating the test environment for b
- out, err = capfd.readouterr()
- assert "ClobberWarning" in err
+ if Version(conda_version) >= Version("24.9.0"):
+ # conda >=24.9.0
+ clobber_warning_found = False
+ for record in caplog.records:
+ if "ClobberWarning:" in record.message:
+ clobber_warning_found = True
+ assert clobber_warning_found
+ else:
+ # before the new lazy index added in conda 24.9.0
+ # see https://github.com/conda/conda/commit/1984b287548a1a526e8258802a6f1fec2a11ecc3
+ out, err = capfd.readouterr()
+ assert "ClobberWarning" in err
+
  with pytest.raises((ClobberError, CondaMultiError)):
  with env_var("CONDA_PATH_CONFLICT", "prevent", reset_context):
  api.build(os.path.join(recipe_dir, "b"), config=testing_config)

tests/test_index.py

@@ -0,0 +1,25 @@
+# Copyright (C) 2014 Anaconda, Inc
+# SPDX-License-Identifier: BSD-3-Clause
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
+import pytest
+from conda.base.context import context
+
+from conda_build.index import get_build_index
+
+if TYPE_CHECKING:
+ from conda_build.metadata import MetaData
+
+
+@pytest.mark.benchmark
+def test_get_build_index(testing_metadata: MetaData) -> None:
+ get_build_index(
+ subdir=context.subdir,
+ bldpkgs_dir=testing_metadata.config.bldpkgs_dir,
+ output_folder=testing_metadata.config.output_folder,
+ clear_cache=True,
+ omit_defaults=True,
+ channel_urls=["local", "conda-forge", "defaults"],
+ )