Create macOS platform tags using packaging #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate the list of macOS platform tags using the mac_platforms function from packaging.tags using a constant macOS version tuple.
Refactor the __init__ method of the PlatformEnv class to parse the platform string into a (operating) system and arch[itecture].
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mariusvniekerk
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Populate the list of supported platforms tags for the macOS platform using the
mac_platformsfunction in packaging.tags. This given a complete listing of platform tags which is also used by pip.This avoiding the need to periodically update a static listing of tags. The new
MACOS_VERSIONvariable will need to be updated periodically to reflect the latest version of macOS.Likely fixes #403 and #436