Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move other regression tests to test_regression #444

Merged

Conversation

mariusvniekerk
Copy link
Collaborator

@mariusvniekerk mariusvniekerk commented Jun 28, 2023

As part the work on #439 I introduced a new test file for the regressions in order to keep the tests a little cleaner.

This moves the other explicit regression tests over to the new location

@mariusvniekerk mariusvniekerk requested a review from a team as a code owner June 28, 2023 18:17
@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 83c5ad5
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/649c794564fee700090cdcab
😎 Deploy Preview https://deploy-preview-444--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes the mypy config more explicit and uniform over tests/.

Moves around a few fixtures and tests to different modules.

LGTM

@maresb
Copy link
Contributor

maresb commented Jun 28, 2023

I've been wanting to move the gdal test within pytest. That should be easy now with that new fixture, right?

@mariusvniekerk mariusvniekerk merged commit f5fa092 into conda:main Jul 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants