Codeql security fixes #2169
Merged
Codeql security fixes #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrect conversion of an unsigned 64-bit integer from to a lower bit size type uint32 without an upper bound check. Signed-off-by: stevenhorsman <steven@uk.ibm.com>
I think this is low risk as it's in test code, but CodeQL throw the warning: > Directly writing user input (for example, an HTTP request parameter) to > an HTTP response without properly sanitizing the input first, allows for > a cross-site scripting vulnerability. so we might as well try and fix it. Signed-off-by: stevenhorsman <steven@uk.ibm.com>
CodeQL is throwing up a high severity error: > Sensitive information that is logged unencrypted is > accessible to an attacker who gains access to the logs. Longer term we might want to log selective fields, or provider a way to just hide the sensitive fields, but for now I've just removed the debug logs that expose things like API Keys Signed-off-by: stevenhorsman <steven@uk.ibm.com>
mkulke
approved these changes
Nov 28, 2024
wainersm
merged commit ac6e23f
into
confidential-containers:main
30 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the 5 CodeQL security alerts we currently have