Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ics20 clarification #1

Merged
merged 1 commit into from
May 25, 2021
Merged

ics20 clarification #1

merged 1 commit into from
May 25, 2021

Conversation

colin-axner
Copy link

No description provided.

Copy link

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better explanation than I had. Happy to merge this in.

I still have an open question what denom looks like when it goes for the second hop. Do we keep prepending multiple hops, or hash then prepend? Or is this left up to each implementation to determine and the sink just needs to know that {denom} is understood by the source?

@ethanfrey ethanfrey merged commit d6466d4 into confio:ics20-cleanup May 25, 2021
@colin-axner colin-axner deleted the colin/ics20-clarification branch May 25, 2021 13:30
@colin-axner
Copy link
Author

colin-axner commented May 25, 2021

I still have an open question what denom looks like when it goes for the second hop. Do we keep prepending multiple hops, or hash then prepend? Or is this left up to each implementation to determine and the sink just needs to know that {denom} is understood by the source?

Hashing is outside the scope of ics20. Hashing the full denomination is a characteristic of ibc-go to avoid denomination validation errors from the SDK. It seems IBC go to market is adopting this as a cornerstone aspect of ics20 so we might want to add it as a recommendation for internal use.

ics20 needs the entire denomination unhashed. Multiple hops just adds the prefix. I wrote up a simplified explanation here. The letter used in the example would just be the destination port/channel

To answer the question directly, we keep prepending once the denomination is received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants