Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS20-1 cleanup #576

Merged
merged 7 commits into from
May 26, 2021
Merged

ICS20-1 cleanup #576

merged 7 commits into from
May 26, 2021

Conversation

ethanfrey
Copy link
Contributor

When preparing to add ICS20-2 documentation, I realized the spec deviated from the implementation, and a few items were underspecified.

In particular:

  • There is no source field in the packet, but important info is encoded in denomination, which is not clearly specified in human words (just pseudocode).
  • The acknowledgement type was incorrect (it is enum with strings, not always success: boolean)
  • It is not defined that the packet data and acknowledgement are JSON-encoded (at least one independent implementation used Protobuf encoding until they debugged compatibility issues)
  • The prefix in the pseudo-code is missing a trailing / that is present in the implementation (and correct in the implementation I believe)

I added these suggests on a "best effort" basis and if the core devs disagree with any of the description, I would ask them to kindly correct this PR. In any case, this PR should be "more correct" than the current master.

@ethanfrey ethanfrey mentioned this pull request May 24, 2021
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending @colin-axner 's clarification.

Thanks for the fix @ethanfrey

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK but see comments - thanks for the improvements!

spec/app/ics-020-fungible-token-transfer/README.md Outdated Show resolved Hide resolved
spec/app/ics-020-fungible-token-transfer/README.md Outdated Show resolved Hide resolved
@cwgoes
Copy link
Contributor

cwgoes commented May 25, 2021

@milosevic Want to take a quick look at this or shall we merge (already 2/3 approvals)?

Copy link
Contributor

@milosevic milosevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work.

@cwgoes cwgoes merged commit 43ec0da into cosmos:master May 26, 2021
@cwgoes
Copy link
Contributor

cwgoes commented May 26, 2021

Merged with 3/3. Thank you @ethanfrey!

@ethanfrey ethanfrey deleted the ics20-cleanup branch May 26, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants