Added the handling of begin and end block events #189

RiccardoM · 2021-05-25T10:32:07Z

This PR adds the support for being_block_events and end_block_events. Closes #188.

The code has been tested locally on a Desmos <-> Band IBC connection and it works properly.

Note

The code currently relies on a fork of the cosmjs/tendermint-rpc package that is available here. This is done because the NPM cosmjs package does not support the required /block_events endpoint. I've already opened a PR towards their repo to implement this feature (see cosmos/cosmjs#810). Until that one is merged, however, we need to rely on the fork.

changeset-bot · 2021-05-25T10:32:09Z

🦋 Changeset detected

Latest commit: a502458

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@confio/relayer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ethanfrey

Nice contribution. Thank you very much.

It is obviously blocked on cosmos/cosmjs#810 being merged and there are a few cleanup items to do, but in general the code looks good. I need to ensure it doesn't break the CI and ideally would like to add a cases for:

Querying still working with v0.41.x (this is broken in the PR, suggestions to fix somehow)
Relaying handles events in a "positive test case" (eg. desmos -> band)

I can take care of setting up the CI to test this, but I would need minimally docker images for both chains as well as a list of setup commands you you to establish this channel and trigger packet creation, so we can verify some endblock transactions properly relayed.

I am fine with doing the CI tests in a separate PR (once both chains are tagged), but it is important to have some test there to prevent future regressions.

ethanfrey · 2021-05-25T11:34:43Z

package.json

@@ -35,7 +35,7 @@
    "@cosmjs/proto-signing": "0.25.3",
    "@cosmjs/stargate": "0.25.3",
    "@cosmjs/stream": "0.25.3",
-    "@cosmjs/tendermint-rpc": "0.25.3",
+    "@cosmjs/tendermint-rpc": "https://gitpkg.now.sh/desmos-labs/cosmjs/packages/tendermint-rpc?riccardo/add-block-search",


Wow, very nice. I never knew how to import non-tagged releases from lerna monorepos

Nice. But where is the TS -> JS compiled?

@webmaster128 I think you can read more here. It should be compiled by them

ethanfrey · 2021-05-25T11:43:36Z

src/lib/endpoint.ts

+    maxHeight,
+  }: QueryOpts = {}): Promise<PacketWithMetadata[]> {
+    const txsPackets = await this.getPacketsFromTxs({ minHeight, maxHeight });
+    const eventsPackets = await this.getPacketsFromBlockEvents({ minHeight, maxHeight });


This will throw an unspecified (and unhandled) error if used on any chain less than tendermint v0.34.9 (cosmos-sdk v0.42.4). I would tend to making this more robust, unless there really is no need to handle earlier chains.

See comments on cosmos/cosmjs#810 (review)

ethanfrey · 2021-05-25T11:45:43Z

src/lib/utils.ts

@@ -96,7 +97,7 @@ export function timestampFromDateNanos(
  const nanos = (date.getTime() % 1000) * 1000000 + (date.nanoseconds ?? 0);
  return Timestamp.fromPartial({
    seconds: new Long(date.getTime() / 1000),
-    nanos,


Lots of small changes from your editor/prettier config.

Can you run yarn fix to bring this into a standard format? (Maybe we need to add an explicit prettier config for the editors.

ethanfrey · 2021-05-25T11:46:41Z

src/lib/utils.ts

    },
    innerSpec: {
      childOrder: [0, 1],
      minPrefixLength: 1,
      maxPrefixLength: 1,
      childSize: 32,
-      hash: HashOp.SHA256,
-    },
+      hash: HashOp.SHA256


Note to self: I think I exposed these in the most recent ics23 package. I should see if I can import them instead of recreating them here.

ethanfrey · 2021-05-25T11:51:52Z

src/lib/utils.ts

@@ -1,9 +1,10 @@
 import { fromUtf8, toHex, toUtf8 } from '@cosmjs/encoding';
 import { BroadcastTxFailure, Coin, logs, StdFee } from '@cosmjs/stargate';
+import { parseEvent } from '@cosmjs/stargate/build/logs';


Importing from the build dir smells funny.
This is kind of exposed top-level

I think you need :

import { logs } from '@cosmjs/stargate'; const { parseEvent } = logs;

ethanfrey · 2021-05-25T11:52:27Z

src/lib/utils.ts

+      }))
+    }));
+
+  const flatEvents = ([] as ParsedEvent[]).concat(allEvents.map(parseEvent));


In any case, nice you do parseEvents to do all the validity checks

ethanfrey · 2021-05-25T11:59:59Z

Oh yeah, you should run yarn changeset to add a line about what feature this adds (it can be a patch release)

RiccardoM · 2021-05-25T12:41:39Z

@ethanfrey I should have fixed everything and added the change set as well

ethanfrey

Looks clean. My main concerns (besides CI integration) have been addressed.

Now waiting the CosmJS PR to be in a tagged release.

Add home option to ics20 command

ethanfrey · 2021-06-21T09:07:19Z

I was looking to prepare this for a merge now, but I think this is still not in a CosmJS release.

Your commit is in cosmjs:main, but I don't see it in the v0.25.4 commit history.

I guess we need to wait til v0.26.0 and update this then?

RiccardoM · 2021-06-21T09:10:32Z

I guess we need to wait til v0.26.0 and update this then?

I guess so, yeah 😢 Any ETA on this @webmaster128?

webmaster128 · 2021-06-21T09:20:19Z

If this is blocking, I'd rather backport the feature to CosmJS 0.25.x than rushing out 0.26.

ethanfrey · 2021-06-21T09:23:03Z

If it can be backported easily, I can update ts-relayer to use it.
I don't know how urgent this is, just one of my pending tasks I wanted to clean up.

@RiccardoM are you using this code now? Or was it just a demo to test compatibility?

RiccardoM · 2021-06-21T09:37:40Z

@RiccardoM are you using this code now? Or was it just a demo to test compatibility?

We will use this feature in the next couple of weeks most likely. We are ending our implementation inside Desmos, then we will perform an on-chain upgrade to release it. Targeting the first week of July, so it might be worth backporting this

ethanfrey · 2021-06-21T09:40:13Z

Nice, I would love to see you using a proper tagged release of the code. Much less compatibility and maintenance headaches

Update registry and README testnets

Tests using cw20-ics20 contract

Add iris installation

webmaster128 · 2021-06-23T11:37:51Z

At cosmos/cosmjs#839 you find a backport of the change. The known limitation is that block height 1 cannot be decoded. The fix for that requires breaking changes. Please have a look and let me know if that would unblock you.

webmaster128 · 2021-06-23T15:42:25Z

CosmJS 0.25.5 should serve your needs now

…nto riccardo/block-results-events # Conflicts: # package.json # yarn.lock

ethanfrey · 2021-06-24T08:23:56Z

@RiccardoM please run yarn fix:prettier to fix up the code, so the CI will run it.

If it passes, I can merge this. I will add release notes for 0.2.0 (changing supported versions) and cut a release with this.

ethanfrey · 2021-06-24T08:42:52Z

Okay, failing test now.
This is cuz we use v0.41.1 simd in the tests.

Do you want to update https://github.com/confio/ts-relayer/blob/main/scripts/simapp/env#L4 to v0.42.4 ?

That should pass.

RiccardoM · 2021-06-24T09:57:12Z

@ethanfrey I've updated the envs and not it passes. I've also opened a new PR (#197) that I think should be included in the next release as well since Band requires custom gas limits to be set to receive packets properly

Added the handling of begin and end block events

d671209

ethanfrey self-requested a review May 25, 2021 11:33

ethanfrey reviewed May 25, 2021

View reviewed changes

RiccardoM added 3 commits May 25, 2021 14:24

Run yarn fix

17b5fb5

Updated chain requirements to have Cosmos v0.42.4 and PR 9081 merged

ec21380

Added changeset entry

1aefddf

ethanfrey approved these changes May 25, 2021

View reviewed changes

Dave Puchyr and others added 3 commits June 9, 2021 14:18

Add home option to ics20 command

a50da75

Add changeset

2a955ea

Merge pull request #191 from iov-one/add-home-to-ics20

c3f0e81

Add home option to ics20 command

ethanfrey added 10 commits June 21, 2021 12:06

musselnet -> oysternet, remove relayer testnets

dcabf3d

Add nyancat testnet

a4035b8

Update README using nyancat

27de19c

Test README demo with nyancat

6f572b5

Add changelog entry

a4c9a31

Prettify README

621c4ed

[skip ci] Point to non-pruning node on nyancat

20906ca

Merge pull request #193 from confio/update-registry-testnets

72cc9fd

Update registry and README testnets

Update blockchain versions

f82ab96

Bump cosmjs to 0.25.4

9033648

ethanfrey and others added 12 commits June 21, 2021 15:41

Prettier js scripts

1b15924

Instantiate contracts in unit test

0045dab

Test channel handshake with ics20 contract

efc8ba3

Send packet with contract

ef2895e

Return token over channel

e74a38f

Expect error on relaying native token over channel

95b61ca

Refactor and remove need for init script

71d5a36

Merge pull request #195 from confio/use-cw20-ics20-contract

752a80a

Tests using cw20-ics20 contract

Bump to v0.1.6

492f554

add iris installation

25ece0b

Minor cleanup for CI

a9fba16

Merge pull request #196 from chengwenxi/vincent-iris

cfbf4cf

Add iris installation

RiccardoM added 9 commits June 24, 2021 07:26

Updated CosmJS to 0.25.5

d5f0ccd

Added the handling of begin and end block events

e88fb01

Run yarn fix

004ee47

Updated chain requirements to have Cosmos v0.42.4 and PR 9081 merged

36afad0

Added changeset entry

b124983

Updated CosmJS to 0.25.5

b382422

Updated CosmJS to 0.25.5

5c5252e

Merge remote-tracking branch 'origin/riccardo/block-results-events' i…

f14a333

…nto riccardo/block-results-events # Conflicts: # package.json # yarn.lock

Reverted custom @cosmjs/tendermint-rpc dependency

ade449b

Run yarn fix:prettier

5343358

Updated simapp environment

a502458

ethanfrey merged commit a4f0205 into confio:main Jun 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the handling of begin and end block events #189

Added the handling of begin and end block events #189

RiccardoM commented May 25, 2021 •

edited

Loading

changeset-bot bot commented May 25, 2021 •

edited

Loading

ethanfrey left a comment

ethanfrey May 25, 2021

webmaster128 Jun 23, 2021

RiccardoM Jun 24, 2021

ethanfrey May 25, 2021

ethanfrey May 25, 2021

ethanfrey May 25, 2021

ethanfrey May 25, 2021

ethanfrey May 25, 2021

ethanfrey commented May 25, 2021

RiccardoM commented May 25, 2021

ethanfrey left a comment

ethanfrey commented Jun 21, 2021

RiccardoM commented Jun 21, 2021

webmaster128 commented Jun 21, 2021

ethanfrey commented Jun 21, 2021

RiccardoM commented Jun 21, 2021

ethanfrey commented Jun 21, 2021

webmaster128 commented Jun 23, 2021

webmaster128 commented Jun 23, 2021

ethanfrey commented Jun 24, 2021

ethanfrey commented Jun 24, 2021

RiccardoM commented Jun 24, 2021

Added the handling of begin and end block events #189

Added the handling of begin and end block events #189

Conversation

RiccardoM commented May 25, 2021 • edited Loading

Note

changeset-bot bot commented May 25, 2021 • edited Loading

🦋 Changeset detected

ethanfrey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ethanfrey commented May 25, 2021

RiccardoM commented May 25, 2021

ethanfrey left a comment

Choose a reason for hiding this comment

ethanfrey commented Jun 21, 2021

RiccardoM commented Jun 21, 2021

webmaster128 commented Jun 21, 2021

ethanfrey commented Jun 21, 2021

RiccardoM commented Jun 21, 2021

ethanfrey commented Jun 21, 2021

webmaster128 commented Jun 23, 2021

webmaster128 commented Jun 23, 2021

ethanfrey commented Jun 24, 2021

ethanfrey commented Jun 24, 2021

RiccardoM commented Jun 24, 2021

RiccardoM commented May 25, 2021 •

edited

Loading

changeset-bot bot commented May 25, 2021 •

edited

Loading