Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proto parsing for unparseable Kafka message #222

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

saithal-confluent
Copy link
Member

@saithal-confluent saithal-confluent commented Aug 20, 2024

Description

Fixed the bug which causes ingestion halt for invalid proto message

When Druid encounters an invalid protobuf kafka message, the ingestion on that partition gets halted as hasNext() method of the FilteringCloseableInputRowIterator.java gets stuck in a endless while loop, until maxParseExceptions is reached.
The fix is to seek the byte buffer to its limit whenever there's a parsing failure. This would allow the buffer to move on and not get stuck at the same place.

Release note

For tips about how to write a good release note, see Release notes.


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@saithal-confluent saithal-confluent requested a review from a team as a code owner August 20, 2024 06:52
Copy link

@pagrawal10 pagrawal10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukul1987 mukul1987 changed the title Fix proto parsing Fix proto parsing for unparseable Kafka message Aug 20, 2024
@saithal-confluent saithal-confluent merged commit 9d78a54 into 25.0.0-confluent Aug 20, 2024
2 checks passed
@saithal-confluent saithal-confluent deleted the sada-20082024-1 branch August 20, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants