Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test to check infinite looping due to ingest parse failure #243

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

saithal-confluent
Copy link
Member

Adds a unit test in FilteringCloseableRowIteratorTest which checks whether there's an infinite looping when an exception raises from ingest parse failures.

Description

A bug related to iterator looping infinitely and thereby halting ingestion was fixed in #222 . Corresponding unit test is being added here to prevent ingestion from halting when a parse exception occurs beyond the set threshold.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note

For tips about how to write a good release note, see Release notes.


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@saithal-confluent saithal-confluent requested a review from a team as a code owner October 8, 2024 16:30
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@saithal-confluent saithal-confluent enabled auto-merge (squash) October 9, 2024 05:26
@saithal-confluent saithal-confluent merged commit 8a7c1b9 into 25.0.0-confluent Oct 9, 2024
3 checks passed
@saithal-confluent saithal-confluent deleted the sada-08102024-2 branch October 9, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants