Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hang in incremental assign during close #4528

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Dec 4, 2023

While using the cooperative assignor, given an assignment is received while closing the consumer
it's possible that it gets stuck in state WAIT_ASSIGN_CALL, while the method is converted to
a full unassign. Solved by changing state from WAIT_ASSIGN_CALL to WAIT_UNASSIGN_CALL
while doing this conversion.

Fixes #4527

@mensfeld
Copy link

@emasab any mitigation possible before it is released?

CHANGELOG.md Outdated
* While using the cooperative assignor, given an assignment is received while closing the consumer
it's possible that it gets stuck in state WAIT_ASSIGN_CALL, while the method is converted to
a full unassign. Solved by changing state from WAIT_ASSIGN_CALL to WAIT_UNASSIGN_CALL
while doing this conversion (#).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
while doing this conversion (#).
while doing this conversion (#4528).

@milindl
Copy link
Contributor

milindl commented Apr 18, 2024

Still some merge conflicts in the changelog but please merge whenever required before/after merging other stuff. Change makes sense to me.

@emasab emasab force-pushed the dev_fix_hang_incremental_assign_during_close branch from 28ef97a to 4c69eb8 Compare April 18, 2024 07:24
because of an assignment op
during consumer close
@emasab emasab force-pushed the dev_fix_hang_incremental_assign_during_close branch from 4c69eb8 to 17f8e81 Compare April 18, 2024 11:33
Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as the 'placeholder' PR + changelog since the changes are already in master from KIP-848 work.

@emasab
Copy link
Contributor Author

emasab commented Apr 18, 2024

Rebased, fix was already included in 848 so have left the CHANGELOG only and a change to TEST_CONSUMER_GROUP_PROTOCOL until we merge #4662

@emasab emasab merged commit dd1e72d into master Apr 18, 2024
2 checks passed
@emasab emasab deleted the dev_fix_hang_incremental_assign_during_close branch April 18, 2024 12:16
anchitj pushed a commit that referenced this pull request Jun 10, 2024
While using the cooperative assignor, given an assignment is received while closing the consumer
it's possible that it gets stuck in state WAIT_ASSIGN_CALL, while the method is converted to
a full unassign. Solved by changing state from WAIT_ASSIGN_CALL to WAIT_UNASSIGN_CALL
while doing this conversion.

Closes #4527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hang if incremental assign is received while consumer is closing
3 participants