Prevent commitSync to bubble up exception to control thread where no exception is caught. #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nscuro
reviewed
Jul 26, 2024
| consumer.commitSync(offsetsToSend); | ||
| // break when offset commit is okay. Do not throw exception to main threads | ||
| break; | ||
| } catch(Throwable t) { |
There was a problem hiding this comment.
Wouldn't it be better to explicitly specify the exceptions that are retriable? You wouldn't want to be stuck in a commit loop if the call has no chance of ever succeeding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved commitSync to a while loop to attempt to commit forever. As soon as brokers are online again, commit will succeed and consumption can resume.
Checklist