fix: safely completing doClose() #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rkolesnev
suggested changes
Aug 12, 2024
...src/main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java
Show resolved
Hide resolved
Closed
2 tasks
Fixes confluentinc#809 Co-authored-by: Roman Kolesnev <romankolesnev@gmail.com>
rkolesnev
approved these changes
Aug 14, 2024
|
/sem-approve |
wushilin
added a commit
to wushilin/parallel-consumer
that referenced
this pull request
Aug 15, 2024
fix: safely completing doClose() (confluentinc#818)
skl83
pushed a commit
to skl83/parallel-consumer
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
doClose()completes and successfully transitions the StreamProcessor to CLOSED state. Unhandled exception duringdoClose()results in a degraded StreamProcessor with terminated control loop but stuck in RUNNING state.This is critical to support accurate external monitoring of
isClosedOrFailed()by user code.see #809
Checklist