This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Load IPC-actors bundle and spawn IPC gateway actor in genesis #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standarize cli/code functions similar to: filecoin-project/lotus#9317 - cctx.NArg() instead of cctx.Args().xxx - Add check for args and print help on functions that did not have it
fix: EthAPI: Drop hack in GetStorageAt
make docsgen-cli
fix: EthAPI: Handle EthCall return correctly
Eth JSON-RPC: implement web3_clientVersion
feat: vm: Assert empty object CID when dumping state
Less strict ArgsCheck
chore: ci: Update codeql to v2
itests: add event matrix tests for realtime eth filters and subscriptions
chore: deps: update FFI, go-state-types, actors to RCs
Eth JSON-RPC: support passing uint64 in JSON-RPC arguments for EthUint64
…-actor Deploy IPC Subnet actor
BundleOverride with `ipc-actors` type for automatic loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on (merge when these are merged):
Goal
The goal of this PR is to load a custom bundle of builtin-actors that include the IPC actors in it, and to spawn the gateway actor in genesis.
Implementation
Usage
At this point, the only thing Lotus does with the IPC actors is loading the bundle and spawning the gateway actor. Theoretically, we should be able to deploy subnet actors and interact with the them, but this hasn't been tested and will be handled in future PRs. In order for Lotus to point to the valid bundle including the IPC actors, the following env variable needs to be exported:
This is the reason why itests fail in genesis, they are not loading the right bundle with the gateway. A future PR is coming next that loads the IPC actors automatically for spacenet without requiring this environmental variable.