-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cri: fix container status #5117
Conversation
Hi @Iceber. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Build succeeded.
|
244fa35
to
75054a0
Compare
Build succeeded.
|
75054a0
to
41ba733
Compare
Build succeeded.
|
41ba733
to
17dbca9
Compare
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
17dbca9
to
92ab1a6
Compare
Build succeeded.
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks!
fix crictl: kubernetes-sigs/cri-tools#724
fix dockershim: kubernetes/kubernetes#99585
In some container states, the startedAt and finishedAt should not be specified
containerd/vendor/k8s.io/cri-api/pkg/apis/runtime/v1alpha2/api.pb.go
Lines 4211 to 4223 in 134f7a7