fix StartedAt and FinishedAt of the container status

[Iceber]

Signed-off-by: Iceber Gu wei.cai-nat@daocloud.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Finished time is always 1754-08-31T06:49:24.128654848+08:05 in the run and create states, because FinishedAt is -6795364578871345152

[root@iceber-3 ~]# crictl inspect 587444fc34ec9
{
  "status": {
    "id": "587444fc34ec9846c163d0c74bbf985ac73662817a89e16b7328b955a03ef902",
    "metadata": {
      "attempt": 6,
      "name": "dx-arch-stolon-sentinel"
    },
    "state": "CONTAINER_RUNNING",
    "createdAt": "2021-03-01T16:45:23.390180141+08:00",
    "startedAt": "2021-03-01T16:45:23.544299436+08:00",
    "finishedAt": "1754-08-31T06:49:24.128654848+08:05",
    "exitCode": 0,

Which issue(s) this PR fixes:

Special notes for your reviewer:

Fixed output in the running state:

[root@iceber-3 ~]# ./crictl inspect 587444fc34ec9
{
  "status": {
    "id": "587444fc34ec9846c163d0c74bbf985ac73662817a89e16b7328b955a03ef902",
    "metadata": {
      "attempt": 6,
      "name": "dx-arch-stolon-sentinel"
    },
    "state": "CONTAINER_RUNNING",
    "createdAt": "2021-03-01T16:45:23.390180141+08:00",
    "startedAt": "2021-03-01T16:45:23.544299436+08:00",
    "finishedAt": "0001-01-01T00:00:00Z",
    "exitCode": 0,

Does this PR introduce a user-facing change?

Fixed `StartedAt` and `FinishedAt` of the container status

[k8s-ci-robot]

Welcome @Iceber!

It looks like this is your first PR to kubernetes-sigs/cri-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cri-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[saschagrunert]

Which container runtime did you use for the tests? I did a local test with CRI-O (master) and the resulting dates for a created container were:

"startedAt": "1970-01-01T01:00:00+01:00",
"finishedAt": "1970-01-01T01:00:00+01:00",

I think we're good to move forward with that change. We could say that it's a breaking change but I would not expect someone to rely on the date parsing output if the container state does not match.

[Iceber]

Which container runtime did you use for the tests? I did a local test with CRI-O (master) and the resulting dates for a created container were:

"startedAt": "1970-01-01T01:00:00+01:00",
"finishedAt": "1970-01-01T01:00:00+01:00",

I think we're good to move forward with that change. We could say that it's a breaking change but I would not expect someone to rely on the date parsing output if the container state does not match.

I did the tests with the dockershim.
You get the 1970-01-01T01:00:00+01:00 because the started and finished timestamp is 0 (zero value)

https://github.com/cri-o/cri-o/blob/6ee8d68771c24a045aef1f5372eae377928a3530/server/container_status.go#L68-L84

The dockershim is use time.Time{}.UnixNano()(-6795364578871345152) as the default timestamp
You can take a look at kubernetes/kubernetes#99585

You can use --debug to see the returned data

[Iceber]

And kubernetes sometimes ignores startedAt and finishedAt when dealing with CRI container status, as seen here

I'm thinking about whether to show "" or 0001-01-01T00:00:00Z(time.Time{}.Format(time.RFC3339Nano)) for empty startedAt and finishedAt
0001-01-01T00:00:00Z has the advantage that it can be parsed by time.Parse without returning errors. And result.IsZero() is true

[saschagrunert]

I'm thinking about whether to show "" or 0001-01-01T00:00:00Z(time.Time{}.Format(time.RFC3339Nano)) for empty startedAt and finishedAt
0001-01-01T00:00:00Z has the advantage that it can be parsed by time.Parse without returning errors. And result.IsZero() is true

In that case it would't be a "breaking change". I like that. 👍

[Iceber]

@saschagrunert update to show 0001-01-01T00:00:00Z.
PTAL, Thanks

[saschagrunert]

/lgtm
/hold for the tests

[saschagrunert]

/hold cancel

the CI failures are not related to this change, I'll follow-up on those.

[saschagrunert]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Iceber, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment