-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci-lint: enable depguard to prevent re-introducing libcontainer #9046
Conversation
Skipping CI for Draft Pull Request. |
This may fail, because the |
@thaJeztah will we only see the fail after merging? Does it work locally just on another version? This change looks good though once we figure that out |
So, I don't think this works currently (unfortunately); the old version just ignores the config, and the new version's config syntax isn't easy to work with for this case (unless I overlooked an option); see |
d28c3ea
to
c59f0df
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
c59f0df
to
cb555fa
Compare
Now that we fully dropped Updated it to guard against |
internal
opencontainers/runc#3028