Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: enable depguard to prevent re-introducing libcontainer #9046

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 1, 2023

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thaJeztah
Copy link
Member Author

This may fail, because the depguard config format changed, so perhaps we need to update golangci-lint first

@thaJeztah thaJeztah changed the title remove uses of github.com/runc/libcontainer/cgroups golangci-lint: enable depguard to prevent re-introducing libcontainer Sep 1, 2023
@dmcgowan
Copy link
Member

dmcgowan commented Sep 5, 2023

@thaJeztah will we only see the fail after merging? Does it work locally just on another version?

This change looks good though once we figure that out

@thaJeztah
Copy link
Member Author

So, I don't think this works currently (unfortunately); the old version just ignores the config, and the new version's config syntax isn't easy to work with for this case (unless I overlooked an option); see

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the depguard_libcontainer branch from c59f0df to cb555fa Compare November 9, 2023 12:24
@thaJeztah thaJeztah marked this pull request as ready for review November 9, 2023 12:24
@thaJeztah
Copy link
Member Author

thaJeztah commented Nov 9, 2023

Now that we fully dropped runc as dependency in #9114, this one became easier to configure.

Updated it to guard against github.com/opencontainers/runc as dependency; this should be ready for review now 👍

@samuelkarp samuelkarp added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@samuelkarp samuelkarp added this pull request to the merge queue Nov 10, 2023
Merged via the queue into containerd:main with commit 45d7f23 Nov 10, 2023
40 checks passed
@thaJeztah thaJeztah deleted the depguard_libcontainer branch November 10, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants