Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MTU as a Route property #1004

Closed
aojea opened this issue Jun 27, 2023 · 2 comments · Fixed by #1041
Closed

Add MTU as a Route property #1004

aojea opened this issue Jun 27, 2023 · 2 comments · Fixed by #1041
Milestone

Comments

@aojea
Copy link

aojea commented Jun 27, 2023

I think this comment from @joestringer is spot on cilium/cilium#23711 (comment)

One possible solution is to teach kubevirt about the route (+MTU) when configuring the devices. By the looks, the CNI spec doesn't encode this today in its routes, but maybe it should encode MTU in the routes there.

cni/pkg/types/types.go

Lines 131 to 134 in e255525

type Route struct {
Dst net.IPNet
GW net.IP
}

For the cases of CNIs that does not use the traditional way of changing the network interface and use routeMTU to handle the discrepancies between interfaces, it will be useful if the plugins will be able to set the mtu directly from the CNI configuration.

@aojea
Copy link
Author

aojea commented Jun 27, 2023

/assign @squeed

@aojea
Copy link
Author

aojea commented Jul 3, 2023

previous work from @mccv1r0 #831

@squeed squeed added this to the CNI v1.1 milestone Jul 3, 2023
Joffref added a commit to Joffref/cni that referenced this issue Jul 4, 2023
Fixes: containernetworking#1004

Signed-off-by: Joffref <mariusjoffre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants