Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MTU to be specified on Route #831

Closed
wants to merge 1 commit into from

Conversation

mccv1r0
Copy link
Member

@mccv1r0 mccv1r0 commented Apr 12, 2021

Allow MTU to be specified on Route

Signed-off-by: Michael Cambria mcambria@redhat.com

@coveralls
Copy link

coveralls commented Apr 12, 2021

Coverage Status

Coverage decreased (-2.9%) to 68.217% when pulling affe2cc on mccv1r0:route-mtu into e33f449 on containernetworking:master.

@dcbw
Copy link
Member

dcbw commented Apr 14, 2021

@mccv1r0 can you add the new field to SPEC.md? Also we'll need to move this struct and associated functions into pkg/types/100/ with MTU, and then into 020 and 040 without the MTU bits.

pkg/types/020/types.go Outdated Show resolved Hide resolved
pkg/types/100/types.go Outdated Show resolved Hide resolved
pkg/types/100/types.go Outdated Show resolved Hide resolved
pkg/types/040/types.go Outdated Show resolved Hide resolved
Signed-off-by: Michael Cambria <mcambria@redhat.com>
@dcbw
Copy link
Member

dcbw commented Apr 19, 2021

@mccv1r0 need to remove Route from pkg/types/types.go and that'll give you a cascade of compile issues. Which basically means you need to change each version's Route to its own rather than types.Route, eg for 020:

type IPConfig struct {
	IP      net.IPNet
	Gateway net.IP
-	Routes  []types.Route
+	Routes  []Route
}

@squeed
Copy link
Member

squeed commented Jun 16, 2021

closing this for now - @mccv1r0, feel free to re-open this if we should pick this back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants