Support DeviceID on Auxiliary Bus #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
Feb 12, 2024
| @@ -53,6 +56,9 @@ type NetConf struct { | |||
| RuntimeConfig struct { | |||
| DeviceID string `json:"deviceID,omitempty"` | |||
| } `json:"runtimeConfig,omitempty"` | |||
|
|
|||
| // for internal use | |||
| AuxDevice string `json:"-"` // Auxiliary device name as appears on Auxiliary bus (/sys/bus/auxiliary) | |||
There was a problem hiding this comment.
If this is internal, it the first word should be lower-cased. Yay golang.
There was a problem hiding this comment.
sure, will align.
noticed that NetConf.DPDKMode may also need to be internal as its inferred from the system[1].
but anyhow, not related to this PR.
[1]
adrianchiris
force-pushed
the
support-sf
branch
from
ecf00fc
to
5531eac
Compare
s1061123
approved these changes
Feb 20, 2024
|
@squeed PTAL again? |
|
@adrianchiris hi, CI (Lint) has some error. Could you please take a look into it? |
@s1061123 we should merge : #1009 then ill rebase this one and we should be good. the lint issues not related to this PR but rather because linter version bumped in CI. |
Device plugins may allocate network device on a bus different than PCI. sriov-network-device-plugin supports the allocation of network devices over Auxiliary bus[1][2][3]. extend host-device CNI to support such devices if provided through runtime config. - Check if device provided by DeviceID runtime config is present on either PCI bus or Auxiliary bus - extend getLink method to support getting netdev link obj from auxiliary bus - add unit-test to cover the new flow [1] https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/tree/master?tab=readme-ov-file#auxiliary-network-devices-selectors [2] https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/tree/master/docs/subfunctions [3] https://docs.kernel.org/networking/devlink/devlink-port.html Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
support-sf
branch
from
5531eac
to
d34720b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device plugins may allocate network device on a bus different than PCI.
sriov-network-device-plugin supports the allocation of network devices over Auxiliary bus[1][2][3].
extend host-device CNI to support such devices if provided through runtime config.
[1] https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/tree/master?tab=readme-ov-file#auxiliary-network-devices-selectors
[2] https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/tree/master/docs/subfunctions
[3] https://docs.kernel.org/networking/devlink/devlink-port.html