-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version of golangci-lint #1009
Merged
squeed
merged 1 commit into
containernetworking:main
from
adrianchiris:fix-lint-version
Mar 11, 2024
Merged
Fix version of golangci-lint #1009
squeed
merged 1 commit into
containernetworking:main
from
adrianchiris:fix-lint-version
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently the workflow will use latest version which is a moving target. newer versions may cause ci failures due to new checks added. Signed-off-by: adrianc <adrianc@nvidia.com>
Example run on main branch with golangci-lint 1.56.1 (which was released a few days ago):
|
austinvazquez
approved these changes
Feb 19, 2024
squeed
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the workflow will use latest
version which is a moving target.
newer versions may cause ci failures due
to new checks added.