-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert /tmp to tmpfs #340
Revert /tmp to tmpfs #340
Conversation
98a6640
to
01cbbbd
Compare
Retried three times, it's not a flake:
Any Windows experts know what's going on with Chocolaty and Golang? |
Ha ha. Now it's failing on git:
So, yeah, must be a flake, I'll just keep hammering on rerun. |
The git flake resolved itself, now it's back to golang failing. There's one difference which I think might be important, having to do with versions vs no-versions:
Maybe the git flake was like a dnf cache delay, where packages just weren't refreshed in repos? |
@containers/podman-maintainers I give up. This needs a Windows expert. |
@l0rd Any ideas? |
Cirrus CI build successful. Found built image names and IDs:
|
Cirrus CI build successful. Found built image names and IDs:
|
YAY! Passed after enough retries!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Packages golang and git are available from the default source ( Anyway chocolately scripting best practices suggest to use a slightly different command to install packages: -- choco install -y --allow-downgrade --execution-timeout=300 $pkg
++ choco upgrade $pkg -y --source="'https://community.chocolatey.org/api/v2'" --allow-downgrade --execution-timeout=300 I have opened a PR to change that but I don't think that this has anything to do with the problems above though. |
/approve |
/hold Let's not merge until we see if this works. My two Podman PRs with these VMs have stuck in CI, twice. I don't know if it's a Cirrus problem or a problem with the VMs. |
@cevich there's something broken somewhere. "Build for debian" is consistently hanging, not even getting started. So is Validate f39. AFAICS there is no indication of why they won't run. How can I debug this? |
01cbbbd
to
9e51093
Compare
They're stuck in 'scheduled' mode. Off-hand, these are container-based Cirrus-CI compute-based tasks. We're not out of credits 🤔 It's running now, so only thing I can think of is: Some kind of Cirrus-CI hiccup. |
Not sure what you mean by "it's running now". Maybe you're referring to "this PR, the /tmp-tmpfs one in automation_images, is running now"? If so, that has nothing to do with anything. The not-running thing is two podman PRs using images I built yesterday. The running-now thing is maybe this PR (the one on which I'm commenting), which I re-pushed in desperation. Maybe yesterday's VMs didn't work because of the Windows outage. I dunno. I'll see what happens in a few minutes. |
Cirrus CI build successful. Found built image names and IDs:
|
|
Oh my bad, I assumed those links were tasks in this repo. I see they're in podman. I just saw a re-push and now the replacement tasks are running over there. This still seems like it was some temporary Cirrus-infra. hiccup. |
BTW: I would strongly recommend testing these images beyond just podman CI. Esp. |
Gah! Hmmmm 🤔 |
Debian grub changed. Not by much, but apparently enough to cause a boot failure.
|
Cause (not root): Boot failure
IIRC, we're using a custom Clearly the base-image is bootable (since cache-image stage is using it and not failing). So it must be something going wrong there. Anything jump out at you in the build logs? |
9e51093
to
df0afa7
Compare
Cirrus CI build successful. Found built image names and IDs:
|
And, back to draft. This must not merge until containers/podman#22207 merges. |
@edsantiago Did you test this out on all the other repos as well? skopeo, common, image, storage... |
I will start opening PRs now on other repos. |
For the last long time, Fedora CI VMs have had a disk /tmp. Real-world setups typically have tmpfs /tmp. This switches to CI VMs that reflect the real world. See containers/automation_images#340 Signed-off-by: Ed Santiago <santiago@redhat.com>
For the last long time, Fedora CI VMs have had a disk /tmp. Real-world setups typically have tmpfs /tmp. This switches to CI VMs that reflect the real world. See containers/automation_images#340 Signed-off-by: Ed Santiago <santiago@redhat.com>
For the last long time, Fedora CI VMs have had a disk /tmp. Real-world setups typically have tmpfs /tmp. This switches to CI VMs that reflect the real world. See containers/automation_images#340 Signed-off-by: Ed Santiago <santiago@redhat.com>
For the last long time, Fedora CI VMs have had a disk /tmp. Real-world setups typically have tmpfs /tmp. This switches to CI VMs that reflect the real world. See containers/automation_images#340 Signed-off-by: Ed Santiago <santiago@redhat.com>
For the last long time, Fedora CI VMs have had a disk /tmp. Real-world setups typically have tmpfs /tmp. This switches to CI VMs that reflect the real world. See containers/automation_images#340 Signed-off-by: Ed Santiago <santiago@redhat.com>
For the last long time, Fedora CI VMs have had a disk /tmp. Real-world setups typically have tmpfs /tmp. This switches to CI VMs that reflect the real world. See containers/automation_images#340 Signed-off-by: Ed Santiago <santiago@redhat.com>
Thanks @edsantiago, I comfortable merging then. I assume you want the podman PR merged first? |
I will merge this, because I'm now more confident that the podman one is likely to merge, and that there are no problems (yet) with the other containers repos. Thank you! |
For the last long time, Fedora CI VMs have had a disk /tmp. Real-world setups typically have tmpfs /tmp. This switches to CI VMs that reflect the real world. See containers/automation_images#340 Signed-off-by: Ed Santiago <santiago@redhat.com>
Thanks for all your efforts on this @edsantiago and @Luap99 😃 |
For the last long time, Fedora CI VMs have had a disk /tmp. Real-world setups typically have tmpfs /tmp. This switches to CI VMs that reflect the real world. See containers/automation_images#340 Signed-off-by: Ed Santiago <santiago@redhat.com>
For the last long time, Fedora CI VMs have had a disk /tmp. Real-world setups typically have tmpfs /tmp. This switches to CI VMs that reflect the real world. See containers/automation_images#340 Signed-off-by: Ed Santiago <santiago@redhat.com>
Podman really needs /tmp to be tmpfs, to detect and
handle reboots. Although there are (at this time) no
reboots involved in CI testing, it's still important
for CI hosts to reflect something close to a real-world
environment. And, there is work underway to check /tmp:
containers/podman#22141
This PR removes special-case Fedora code that was
disabling a tmpfs /tmp mount. History dates back to
PR #30 back in 2020.
Some of the image-build code in this repo performs
reboots and relies on persistent tmp files, so you'll
note a flurry of /tmp -> /var/tmp changes.
And, as a drive-by, document the Windows Chocolatey
install command. Link to Best Practices, and explain
why we disregard some of those.
Signed-off-by: Ed Santiago santiago@redhat.com