Bump automation library version #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I assume this addresses the issue you reported in your |
Thanks, and yes. |
Merged
cevich
force-pushed
the
bump_automation_lib
branch
from
8099349 to
28b7868
Compare
|
Ugh, that |
Importantly, this contains a necessary fix for `build_push.sh` needed to stop immutable-image existence-check failing on build (c/image_build cron job). Signed-off-by: Chris Evich <cevich@redhat.com>
Previously this task depended on executing a downstream test script intended for exercising an orthagonal orchestration script (which happens to call `build-push.sh`. Having upstream CI VM image builds depend on a downstream script is very much not ideal. Replace this with a very quick/dirty test that simply confirms a multi-arch build can function. Signed-off-by: Chris Evich <cevich@redhat.com>
Many/most of the container image builds rely on pulling packages from repos that are sometimes slow/busy. Give the tasks a bit of extra time in case it's needed. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
force-pushed
the
bump_automation_lib
branch
from
28b7868 to
c3a0ca1
Compare
|
Cirrus CI build successful. Found built image names and IDs:
|
|
Oops, I missed the
|
|
Thanks Ed, no worries. I just needed the build-push VM image to fix our ailing 'immutable' builds. The real interesting stuff is going to be in #349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importantly, this contains a necessary fix for
build_push.shneeded to stop immutable-image existence-check failing on build (c/image_build cron job).