Add Pull Request Template #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a pull request template. Modeled after CRI-O (Thanks @saschagrunert!) and Dockers. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
rhatdan
reviewed
Mar 3, 2020
|
|
||
| Please make sure you've read and understood our contributing guidelines | ||
| (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring | ||
| that all your commits are signed with `git commit -s`. |
There was a problem hiding this comment.
Is there anything to make this automatic?
There was a problem hiding this comment.
I'm not sure, need to dig further. It certainly would be nice if we could pull that off.
There was a problem hiding this comment.
Hm no I don't think we could automate this without having a write access token to the repository.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 4, 2020
2201: Add Pull Request Template r=rhatdan a=TomSweeneyRedHat Add a pull request template. Modeled after CRI-O (Thanks @saschagrunert!) and Dockers. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Co-authored-by: TomSweeneyRedHat <tsweeney@redhat.com>
Build failed
|
rhatdan
approved these changes
Mar 4, 2020
|
bors retry |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pull request template. Modeled after CRI-O (Thanks @saschagrunert!) and
Dockers.
Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com