-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pull Request Template #2201
Merged
+66
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
<!-- | ||
Thanks for sending a pull request! | ||
Please make sure you've read and understood our contributing guidelines | ||
(https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring | ||
that all your commits are signed with `git commit -s`. | ||
--> | ||
|
||
#### What type of PR is this? | ||
|
||
<!-- | ||
Please label this pull request according to what type of issue you are | ||
addressing, especially if this is a release targeted pull request. | ||
Uncomment only one `/kind <>` line, hit enter to put that in a new line, and | ||
remove leading whitespace from that line: | ||
--> | ||
|
||
> /kind api-change | ||
> /kind bug | ||
> /kind cleanup | ||
> /kind deprecation | ||
> /kind design | ||
> /kind documentation | ||
> /kind failing-test | ||
> /kind feature | ||
> /kind flake | ||
> /kind other | ||
#### What this PR does / why we need it: | ||
|
||
#### How to verify it | ||
|
||
#### Which issue(s) this PR fixes: | ||
|
||
<!-- | ||
Automatically closes linked issue when PR is merged. | ||
Uncomment the following comment block and include the issue | ||
number or None on one line. | ||
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`, or `None`. | ||
--> | ||
|
||
<!-- | ||
Fixes # | ||
or | ||
None | ||
--> | ||
|
||
#### Special notes for your reviewer: | ||
|
||
#### Does this PR introduce a user-facing change? | ||
|
||
<!-- | ||
If no, just write `None` in the release-note block below. If yes, a release note | ||
is required: Enter your extended release note in the block below. If the PR | ||
requires additional action from users switching to the new release, include the | ||
string "action required". | ||
For more information on release notes please follow the kubernetes model: | ||
https://git.k8s.io/community/contributors/guide/release-notes.md | ||
--> | ||
|
||
```release-note | ||
``` | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything to make this automatic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, need to dig further. It certainly would be nice if we could pull that off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm no I don't think we could automate this without having a write access token to the repository.