-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/containerd/containerd from 1.6.19 to 1.7.0 #4656
build(deps): bump github.com/containerd/containerd from 1.6.19 to 1.7.0 #4656
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vrothberg @cevich any idea why the vendoring is always broken on these updates? |
The Renovate flavored update is similarly broken: #4652 |
@mtrmac IIRC you made a comment relating to this recently. I believe the gist was: The most optimal solution is doing the manual grunt-work to make it right. I don't know how golang modules & vendoring works well enough to comment further. I know in the case of renovate, there's an option to run If I have a vote, I'd actually prefer the renovate PR gets fixed and merged as opposed to this one. Since the point is to phase-out Dependabot. |
Those seem to be different problems to me:
|
Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.6.19 to 1.7.0. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.6.19...v1.7.0) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
c6de1f7
to
6f198c2
Compare
Testing that, running the existing |
@cevich I have manually updated the Renovate PR. I’m not at all sure it works better that way, see that PR for a more detailed explanation. |
Oh… here is me lazily spinning theories, while Renovate Has An Option For That™️ : https://docs.renovatebot.com/modules/manager/gomod/ has flags like Looking a bit further, maybe the ideal fix is to bump the
|
Filed #4662, let’s see… Then we can let the tools rebase their PRs, and we’ll see if that actually helped. |
Looks like github.com/containerd/containerd is up-to-date now, so this is no longer needed. |
Bumps github.com/containerd/containerd from 1.6.19 to 1.7.0.
Release notes
Sourced from github.com/containerd/containerd's releases.
... (truncated)
Changelog
Sourced from github.com/containerd/containerd's changelog.
... (truncated)
Commits
1fbd703
Merge pull request #8242 from dmcgowan/prepare-v1.7.0e13a916
Prepare release notes for v1.7.0e92e692
Merge pull request #8241 from AkihiroSuda/deprecation-202303090fe3b49
Merge pull request #8232 from panguicai008/flag-usage2168015
Merge pull request #8240 from davidhsingyuchen/client-install-doc625217d
RELEASES.md: describe the deprecated config properties8cc09e6
Merge pull request #8233 from dmcgowan/prepare-v1.7.0-rc.3703e2ba
docs: link docs/managed-opt.md to client.Install1f236dc
Merge pull request #8237 from AkihiroSuda/go-1.20.2f2bb9c9
Go 1.20.2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)