Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.18 #1827

Merged
merged 9 commits into from
Feb 3, 2023
Merged

Update to Go 1.18 #1827

merged 9 commits into from
Feb 3, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Feb 3, 2023

We already depend on Go 1.18, due to:

vendor/github.com/rivo/uniseg/properties.go:func propertySearch[E interface{ [3]int | [4]int }](dictionary []E, r rune) (result E) {

So, actually update c/image proper, and take advantage of the new features.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

Changes LGTM, Skope test isn't happy. Might be a flake, but I'm unsure.

FAIL: sync_test.go:340: SyncSuite.TestYaml2Dir
Running skopeo sync --scoped --src yaml --dest dir /tmp/check-1124721257/18/registries.yaml /tmp/check-1124721257/18/dir1
sync_test.go:374:
    assertSkopeoSucceeds(c, "", "sync", "--scoped", "--src", "yaml", "--dest", "dir", yamlFile, dir1)
utils.go:67:
    c.Assert(err, check.IsNil, check.Commentf("%s", out))
... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc00011a288), Stderr:[]uint8(nil)} ("exit status 1")
... time="2023-02-02T19:30:53-06:00" level=info msg="Processing repo" registry=k8s.gcr.io repo=pause
.
.
.
Copying blob sha256:9c075fe2c773108d2fe2c18ea170548b0ee30ef4e5e072d746e3f934e788b734
time="2023-02-02T19:30:56-06:00" level=fatal msg="Error copying ref \"docker://quay.io/quay/busybox:latest\": writing blob: happened during read: unexpected EOF"

@mtrmac
Copy link
Collaborator Author

mtrmac commented Feb 3, 2023

Yes, quay.iounexpected EOF are known infrastructure issues. I really need to finish #1816

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... in almost all cases.

Also rename mSI (map[string]interface{}) to mSA (map[string]any).

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Let's not even suggset that it it might be necessary to
allocate memory for a value.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This avoid some unnecessary uses of interface{}, and allows us to
pass existing functions to otherJSONParser without needing an extra
type conversion thunk.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Collaborator Author

mtrmac commented Feb 3, 2023

Rebased, tests pass.

@rhatdan
Copy link
Member

rhatdan commented Feb 3, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants