Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm/update-config-files: zstd:chunked not enabled in Fedora yet #2208

Merged

Conversation

@travier travier force-pushed the main-no-zstdchunked-yet branch from 9f0e257 to 1ad44cb Compare October 21, 2024 10:49
@mheon
Copy link
Member

mheon commented Oct 21, 2024

Sure, LGTM. We threw this in an RPM patch so the latest F41 builds are fine.

@Luap99
Copy link
Member

Luap99 commented Oct 21, 2024

@lsm5 PTAL

@rhatdan
Copy link
Member

rhatdan commented Oct 21, 2024

LGTM

@travier
Copy link
Member Author

travier commented Oct 21, 2024

Sure, LGTM. We threw this in an RPM patch so the latest F41 builds are fine.

Yes, saw that earlier. I was thinking "let's push it upstream so that we don't forget it".

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 88d52c6 into containers:main Oct 22, 2024
16 checks passed
@lsm5
Copy link
Member

lsm5 commented Oct 22, 2024

sorry for the late response. LGTM

lsm5 added a commit to lsm5/common that referenced this pull request Oct 22, 2024
Already added to the Fedora package.

@travier has fixed this on main in containers#2208.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@travier travier deleted the main-no-zstdchunked-yet branch October 22, 2024 15:13
@cgwalters
Copy link
Contributor

Additional followup in #2213

lsm5 added a commit to lsm5/common that referenced this pull request Oct 23, 2024
Already added to the Fedora package.

Fixed in main with containers#2208.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5 added a commit to lsm5/common that referenced this pull request Oct 28, 2024
Fixed in main with containers#2208 and containers#2213.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants