Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci][v0.60] RPM: do not set zstd:chunked default anywhere #2211

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Oct 22, 2024

Fixed in main with #2208 and #2213.

Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

@travier: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@travier
Copy link
Member

travier commented Oct 22, 2024

@lsm5 Can you remove the @travier from the commit message please? Otherwise I'll get mentioned every time someone pushes this commit somewhere on GitHub. Thanks

@lsm5 lsm5 force-pushed the no-zstd-in-fedora branch from 67d4350 to 64b8b4c Compare October 23, 2024 11:41
@lsm5
Copy link
Member Author

lsm5 commented Oct 23, 2024

@lsm5 Can you remove the @travier from the commit message please? Otherwise I'll get mentioned every time someone pushes this commit somewhere on GitHub. Thanks

done. sorry about the noise.

Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

@travier: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -57,7 +57,7 @@ fi

# Set these on Fedora Rawhide (41+), RHEL 10+, and on all COPR builds
# regardless of distro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please backport the comment update as well, so that it is consistent with the code.

LGTM otherwise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also included changes from #2213. PTAL

@mtrmac mtrmac changed the title [skip-ci] RPM: zstd:chunked not enabled in Fedora yet [skip-ci][v0.60] RPM: zstd:chunked not enabled in Fedora yet Oct 25, 2024
Fixed in main with containers#2208 and containers#2213.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5 lsm5 force-pushed the no-zstd-in-fedora branch from 64b8b4c to b033feb Compare October 28, 2024 11:39
@lsm5 lsm5 changed the title [skip-ci][v0.60] RPM: zstd:chunked not enabled in Fedora yet [skip-ci][v0.60] RPM: do not set zstd:chunked default anywhere Oct 28, 2024
@mheon
Copy link
Member

mheon commented Oct 28, 2024

LGTM

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, lsm5, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4188424 into containers:v0.60 Oct 29, 2024
13 checks passed
@lsm5 lsm5 deleted the no-zstd-in-fedora branch December 17, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants