Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimage: prune: allow for removing external containers #785

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

vrothberg
Copy link
Member

Support pruning images in use by external containers (e.g., build
containers). Requires extending the containers filter, adding a
callback to libpod and a new options for image removal.

Tests will be added to Podman.

Signed-off-by: Valentin Rothberg rothberg@redhat.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member Author

Counterpart in Podman: containers/podman#11737

@rhatdan PTAL

@rhatdan
Copy link
Member

rhatdan commented Sep 24, 2021

Looks alright but tests are not happy.

@vrothberg
Copy link
Member Author

Looks alright but tests are not happy.

Fixed. Was a fart in the test.

@vrothberg
Copy link
Member Author

/hold
Will continue working on it on Monday.

To fix some flakes in CI.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Support pruning images in use by external containers (e.g., build
containers).  Requires extending the containers filter, adding a
callback to libpod and a new options for image removal.

Tests will be added to Podman.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg
Copy link
Member Author

containers/podman#11737 is green, ready to merge from my side.

@mheon @rhatdan PTAL

@rhatdan
Copy link
Member

rhatdan commented Sep 27, 2021

@vrothberg
Copy link
Member Author

@Luap99 PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vrothberg
Copy link
Member Author

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 32e2029 into containers:main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants