-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libimage: prune: allow for removing external containers #785
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Counterpart in Podman: containers/podman#11737 @rhatdan PTAL |
Looks alright but tests are not happy. |
Fixed. Was a fart in the test. |
/hold |
050a131
to
b493e1b
Compare
To fix some flakes in CI. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Support pruning images in use by external containers (e.g., build containers). Requires extending the containers filter, adding a callback to libpod and a new options for image removal. Tests will be added to Podman. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
containers/podman#11737 is green, ready to merge from my side. |
LGTM |
@Luap99 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
Support pruning images in use by external containers (e.g., build
containers). Requires extending the containers filter, adding a
callback to libpod and a new options for image removal.
Tests will be added to Podman.
Signed-off-by: Valentin Rothberg rothberg@redhat.com