Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image prune: support removing external containers #11737

Merged
merged 1 commit into from
Sep 28, 2021
Merged

image prune: support removing external containers #11737

merged 1 commit into from
Sep 28, 2021

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Sep 24, 2021 •
edited
Loading

Support removing external containers (e.g., build containers) during
image prune.

Fixes: #11472
Signed-off-by: Valentin Rothberg rothberg@redhat.com

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2021
This was referenced Sep 24, 2021
Merged
Closed
@vrothberg
Copy link
Member Author

@mheon PTAL

@vrothberg
Copy link
Member Author

And @edsantiago PTAL. Apologies for the extra 5 seconds in the tests, I saw no other option assuming the ps tests need to exercise podman-rm.

@mheon
Copy link
Member

mheon commented Sep 24, 2021

Probably the best solution we're going to get for now. Mostly LGTM with one comment.

@vrothberg
Copy link
Member Author

And @edsantiago PTAL. Apologies for the extra 5 seconds in the tests, I saw no other option assuming the ps tests need to exercise podman-rm.

Fresh Monday morning brain helped to massage it into the ps --external test. I think that's preferable over 5 extra seconds.

@vrothberg vrothberg mentioned this pull request Sep 27, 2021
Merged
rhatdan
rhatdan reviewed Sep 27, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@rhatdan rhatdan changed the title image prune: support removing external containers [wip] image prune: support removing external containers Sep 27, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2021
@vrothberg vrothberg mentioned this pull request Sep 28, 2021
Merged
@vrothberg
image prune: support removing external containers
a9a54ee 
Support removing external containers (e.g., build containers) during
image prune.

Fixes: containers#11472
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg vrothberg changed the title [wip] image prune: support removing external containers image prune: support removing external containers Sep 28, 2021
@vrothberg
Copy link
Member Author

Now vendoring c/common, @containers/podman-maintainers PTAL

@openshift-ci openshift-ci bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 28, 2021
giuseppe
giuseppe approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member Author

@Luap99 PTAL

edsantiago
edsantiago approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test LGTM. Thanks for piggybacking on existing test.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, giuseppe, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [edsantiago,giuseppe,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member

Luap99 commented Sep 28, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2021
@vrothberg
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit f2ffb96 into containers:main Sep 28, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon mheon left review comments

@rhatdan rhatdan rhatdan left review comments

@edsantiago edsantiago edsantiago approved these changes

@giuseppe giuseppe giuseppe approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to remove image, image is in use by container
7 participants
@vrothberg @mheon @Luap99 @giuseppe @edsantiago @rhatdan @openshift-merge-robot