update CONTRIBUTING docs with new links and new module layout #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
reviewed
Sep 1, 2025
Port the podman fix[1] over here as well. We only need a the github number or the link not both. [1] containers/podman@c39fd06 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Update the commands and examples to use the new go.podman.io paths. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
mtrmac
reviewed
Sep 2, 2025
Add the subsections of "Submitting Pull Requests" and the missing "Unit Tests" header in CONTRIBUTING_GO.md. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
(Previously containers/common#2481 .) |
Uh that sucks, I have seen some weird golangci-lint stuff in the past. Of course locally it runs fine. I also just rerun the github actions to rule out a flake. |
|
Filed #314 to shut lint up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits