Fix various lint issues #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, it is gated behind a build tag, but it still breaks golangci-lint runs on macOS without being explicitly OS-specific. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
The "o == nil" check was confusing staticcheck into thinking it might be nil even _after_ the Fatalf (apparently it doesn't recognize that that terminates). Instead, simplify, drop that extra condition, and if we ever got a nil, we are going to crash. *shrug*, less test code to maintain in the future. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Luap99
approved these changes
Sep 4, 2025
|
|
||
| func openDirectory(path string) (fd int, err error) { | ||
| const O_PATH = 0x00400000 | ||
| // FIXME: If O_PATH is not defined on a platform, it probably doesn't work. E.g. on macOS, this is actually O_DSYNC. |
There was a problem hiding this comment.
I think this was just added for freebsd so I guess we should just make the package compile there since we won't support this code path elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint failures on macOS slow down other work.
We also, occasionally, get a lint warning in
pkg/manifests(e.g. commit 36a4061 ). Shut that one up as well.See individual commit messages for details.