Be more explicit about the port part of a certificate directory #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as highlighted in containers/podman#26567 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
Fixes containers/podman#26567 . |
3nprob
reviewed
Oct 3, 2025
| # DESCRIPTION | ||
| A custom TLS configuration for a container registry can be configured by creating a directory under `$HOME/.config/containers/certs.d` or `/etc/containers/certs.d`. | ||
| The name of the directory must correspond to the `host:port` of the registry (e.g., `my-registry.com:5000`). | ||
| The name of the directory must correspond to the `host`[`:port`] of the registry (e.g., `my-registry.com:5000`). |
There was a problem hiding this comment.
Suggested change
| The name of the directory must correspond to the `host`[`:port`] of the registry (e.g., `my-registry.com:5000`). | |
| The name of the directory must correspond to the `host`[`:port`] of the registry, where `:port` must be omitted in case of port `443` but is otherwise required (e.g., `my-registry.com:5000` or `registry.example.com`). |
There was a problem hiding this comment.
That’s not actually correct - if users pull registry.example.com:443/…, the directory must be named registry.example.com:443. 443/80 are not special for this purpose.
There was a problem hiding this comment.
Hm, right. I still find the proposal can cause confusion (one interpretation being that the :port is optional.
How about using "prefix", "registry" or "location" instead of "host[:port]" - which would reuse notation from containers-registries.conf docs and indicating that the following explanation is required reading?
(Aside: Elsewhere it seems that hostname:port is used more than host:port)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as highlighted in containers/podman#26567 .