Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile improvements #324

Closed
hferentschik opened this issue Aug 11, 2017 · 2 comments
Closed

Makefile improvements #324

hferentschik opened this issue Aug 11, 2017 · 2 comments

Comments

@hferentschik
Copy link
Contributor

I suggest some Makefile improvements which I added while working isuee #155.
hferentschik added a commit to hferentschik/image that referenced this issue Aug 11, 2017
@hferentschik
Issue containers#324 Adding a build target and ensure compilation on …
3ae0fe1 
…macOS

- Making sure that build target can handle build tags and build on macOS
- Adding target to go fmt target
hferentschik added a commit to hferentschik/image that referenced this issue Aug 11, 2017
@hferentschik
Issue containers#324 Making sure all vendored logrus usages use the l…
6cfe3b7 
…owercase import
hferentschik added a commit to hferentschik/image that referenced this issue Aug 12, 2017
@hferentschik
Issue containers#324 Adding a build target and ensure compilation on …
9b2faf5 
…macOS

- Making sure that build target can handle build tags and build on macOS
- Adding target to go fmt target
hferentschik added a commit to hferentschik/image that referenced this issue Aug 12, 2017
@hferentschik
Issue containers#324 Making sure all vendored logrus usages use the l…
2fcd6fb 
…owercase import
hferentschik added a commit to hferentschik/image that referenced this issue Aug 14, 2017
@hferentschik
Issue containers#324 Adding a build target and ensure compilation on …
a91704d 
…macOS

- Making sure that build target can handle build tags and build on macOS
- Adding target to go fmt target

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
hferentschik added a commit to hferentschik/image that referenced this issue Aug 14, 2017
@hferentschik
Issue containers#324 Making sure all vendored logrus usages use the l…
5ac673a 
…owercase import

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
hferentschik added a commit to hferentschik/image that referenced this issue Aug 17, 2017
@hferentschik
Issue containers#324 Making sure all vendored logrus usages use the l…
4e63d38 
…owercase import

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
This was referenced Aug 22, 2017
Merged
Closed
hferentschik added a commit to hferentschik/image that referenced this issue Oct 3, 2017
@hferentschik
Issue containers#324 Adding a build target and ensure compilation on …
6551acd 
…macOS

- Making sure that build target can handle build tags and build on macOS
- Adding target to go fmt target

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
hferentschik added a commit to hferentschik/image that referenced this issue Oct 3, 2017
@hferentschik
Issue containers#324 Making sure all vendored logrus usages use the l…
406b3dc 
…owercase import

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
hferentschik added a commit to hferentschik/image that referenced this issue Oct 3, 2017
@hferentschik
Issue containers#324 Adding a build target and ensure compilation on …
75d42cb 
…macOS

- Making sure that build target can handle build tags and build on macOS
- Adding target to go fmt target
- Changing the order of the subtargets of all

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>

foo
hferentschik added a commit to hferentschik/image that referenced this issue Oct 3, 2017
@hferentschik
Issue containers#324 Making sure all vendored logrus usages use the l…
ae44adc 
…owercase import

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
hferentschik added a commit to hferentschik/image that referenced this issue Oct 5, 2017
@hferentschik
Issue containers#324 Adding build target
6e1bfbe 
- Adding target to go fmt target
- Changing the order of the subtargets of all

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
hferentschik added a commit to hferentschik/image that referenced this issue Oct 5, 2017
@hferentschik
Issue containers#324 Adding build target
f4e9466 
- Adding target to go fmt target
- Changing the order of the subtargets of all

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
hferentschik added a commit to hferentschik/image that referenced this issue Oct 5, 2017
@hferentschik
Issue containers#324 Adding build target
bb6abe4 
- Adding target to go fmt target
- Changing the order of the subtargets of all

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
hferentschik added a commit to hferentschik/image that referenced this issue Oct 31, 2017
@hferentschik
Issue containers#324 Adding build target
7718431 
- Adding target to go fmt target
- Changing the order of the subtargets of all

Signed-off-by: Hardy Ferentschik <hardy@hibernate.org>
runcom added a commit that referenced this issue Oct 31, 2017
@runcom
Merge pull request #325 from hferentschik/issue-324
583e84d 
Issue #324 Adding build and fmt target
@rhatdan
Copy link
Member

rhatdan commented Apr 25, 2019

@vdemeester @mtrmac @vrothberg Is this still an issue? Can we close it?

@vdemeester
Copy link
Contributor

I think it's closeable indeed 😉

@rhatdan rhatdan closed this as completed Apr 25, 2019
@edsantiago edsantiago mentioned this issue Mar 21, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vdemeester @hferentschik @rhatdan