-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency containers/automation_images to v20240320 #2354
Conversation
Failure in validate:
|
That’s quite possibly some old cruft in |
Trying to update this, following in the footsteps of #2355 . |
@@ -66,7 +66,7 @@ tools: .install.gitvalidation .install.golangci-lint | |||
|
|||
.install.gitvalidation: | |||
if [ ! -x "$(GOBIN)/git-validation" ]; then \ | |||
GO111MODULE="off" go get $(BUILDFLAGS) github.com/vbatts/git-validation; \ | |||
go install github.com/vbatts/git-validation@latest; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is obviously the part I missed. LGTM.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This use of (go get) was deprecated back in Go 1.18. Also don't use our build tags for building unrelated tools. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
It's the default since Go 1.16. In theory the environment might be setting it to off, and breaking our builds; unless something compelling comes up, I think that hypothetical environment should be changed, nowadays. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
9a46c6a
to
b6b60bf
Compare
This PR contains the following updates:
20240125t184057z-f39f38d13
->20240320t153921z-f39f38d13
Release Notes
containers/automation_images (containers/automation_images)
v20240320t153921z-f39f38d13
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.