-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5.19, backport] storage: use race-free AddNames
instead of SetNames
#1503
Conversation
Signed-off-by: Aditya R <arajan@redhat.com>
Commits from parallel builds using `SetNames` removes `names` from storage for other builds. Use race-free atomic `AddNames` to prevent breaking of parallel builds. Signed-off-by: Aditya R <arajan@redhat.com>
Signed-off-by: Aditya R <arajan@redhat.com>
@mtrmac @vrothberg PTAL this backports the needed commit, could we cut a |
I think CI is not getting triggered because of github outage or could it be something else ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass. Thanks!
Sure. Would you like to prepare the usual two-commit PR? Compare https://github.com/containers/image/pull/1457/commits . |
@mtrmac I have added two consecutive commits in this same PR, i wonder if i just need to add |
Signed-off-by: Aditya R <arajan@redhat.com>
@mtrmac bumped to |
I was kinda thinking of a separate PR, but this works just as well and saves us some CI time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming tests pass.
@mtrmac tests are green now :D |
Partially addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2066519 and https://bugzilla.redhat.com/show_bug.cgi?id=2055487 |
Exceptions approved: RHEL 9.0 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2066519 RHEL 8.6 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2055487 |
Backport of: #1480
Commits from parallel builds using
SetNames
removesnames
fromstorage for other builds.
Use race-free atomic
AddNames
to prevent breaking of parallel builds.