[v5.16, backport] storage: use race-free AddNames instead of SetNames
#1512
Conversation
Podman `v3.4.2-rhel` and buildah release `1.23` branch uses `c/image 5.16.0` which needs `v1.36.3` of `c/storage` Signed-off-by: Aditya R <arajan@redhat.com>
Commits from parallel builds using `SetNames` removes `names` from storage for other builds. Use race-free atomic `AddNames` to prevent breaking of parallel builds. Signed-off-by: Aditya R <arajan@redhat.com>
Signed-off-by: Aditya R <arajan@redhat.com>
Signed-off-by: Aditya R <arajan@redhat.com>
|
@mtrmac PTAL. I am just concerned about why |
| @@ -8,7 +8,7 @@ require ( | |||
| github.com/containerd/containerd v1.5.4 // indirect | |||
| github.com/containers/libtrust v0.0.0-20190913040956-14b96171aa3b | |||
| github.com/containers/ocicrypt v1.1.2 | |||
| github.com/containers/storage v1.37.0 | |||
| github.com/containers/storage v1.36.3 | |||
There was a problem hiding this comment.
This is not acceptable.
(Alternative approaches are being discussed, just noting this here so that it doesn’t get merged as is.)
There was a problem hiding this comment.
@TomSweeneyRedHat @mheon FYI this is sort of a trouble where we are stuck and discussing an alternative approach.
There was a problem hiding this comment.
@flouthoc looks like a good Cabal topic. Could you add it to the list please?
There was a problem hiding this comment.
@TomSweeneyRedHat I created this PR for v3.4.2-rhel but afaik the backport for v3.4.2-rhel is not decided so we might not need this PR anymore.
|
|
|
Closing in favor of #1519 ; please speak up if that’s incorrect. |
Backport of: #1480
Similar to: #1503
Commits from parallel builds using
SetNamesremoves names fromstorage for other builds.
Use race-free atomic
AddNamesto prevent breaking of parallel builds.