Downgrade siruspen/logrus from 1.5 to 1.4.2 #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade of logrus forces to update the dependency in go module consumers as well. The new locking in logrus 1.5.0 introduces regressions in conjunction to deadlocks when using custom hooks, which is the case in CRI-O for example. Having it point to v1.5.0 here is forcing cri-o to upgrade it as well when we update c/image to 5.3.1. Let's downgrade logrus till sirupsen/logrus#1122 is fixed. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
LGTM |
mtrmac
reviewed
Apr 3, 2020
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
Woops, fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade of logrus forces to update the dependency in go module
consumers as well.
The new locking in logrus 1.5.0 introduces regressions in conjunction to
deadlocks when using custom hooks, which is the case in CRI-O for
example.
Having it point to v1.5.0 here is forcing cri-o to upgrade it as well
when we update c/image to 5.3.1.
Let's downgrade logrus till sirupsen/logrus#1122
is fixed.
And bump up the version to 5.4.1
Signed-off-by: Urvashi Mohnani umohnani@redhat.com