Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade siruspen/logrus from 1.5 to 1.4.2 #885

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Downgrade siruspen/logrus from 1.5 to 1.4.2 #885

merged 3 commits into from
Apr 3, 2020

Commits on Apr 3, 2020

  1. Downgrade siruspen/logrus from 1.5 to 1.4.2 

    The upgrade of logrus forces to update the dependency in go module
consumers as well.

The new locking in logrus 1.5.0 introduces regressions in conjunction to
deadlocks when using custom hooks, which is the case in CRI-O for
example.

Having it point to v1.5.0 here is forcing cri-o to upgrade it as well
when we update c/image to 5.3.1.

Let's downgrade logrus till sirupsen/logrus#1122
is fixed.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
    @umohnani8
    umohnani8 committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    97e8870 View commit details
    Browse the repository at this point in the history

  2. Bump version to 5.4.1 

    Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
    @umohnani8
    umohnani8 committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    3f1c51b View commit details
    Browse the repository at this point in the history

  3. Bump version to 5.4.2-dev 

    Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
    @umohnani8
    umohnani8 committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    cb5b366 View commit details
    Browse the repository at this point in the history