Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload as OCI image on push #25

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

isinyaaa
Copy link
Contributor

@isinyaaa isinyaaa commented Oct 31, 2024

This changes the config type to match the OCI spec, and the layer types are now encoded as a tar blob without any compression.

Artifact upload can still be used with the as-artifact flag/option.

TODO:

  • update docs examples
  • verify OCI image

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@isinyaaa isinyaaa force-pushed the push-xpzxprvquopn branch 9 times, most recently from 9fa7d9e to 37c672c Compare November 1, 2024 00:16
@isinyaaa isinyaaa force-pushed the push-xpzxprvquopn branch 2 times, most recently from b00c2bf to 0eab0c9 Compare November 1, 2024 00:25
@tarilabs
Copy link
Member

tarilabs commented Nov 4, 2024

wrt to the failure with Quay, I would check if this example works by spinning Quay using the e2e .sh script, and trying it out. If the K8s example passes, it might be then symptom something is not fully aligned?

@isinyaaa isinyaaa force-pushed the push-xpzxprvquopn branch 2 times, most recently from 4f8c222 to 9fc1337 Compare November 11, 2024 18:33
@isinyaaa
Copy link
Contributor Author

seems like the fix for quay is this: isinyaaa/oras-py#1

@isinyaaa
Copy link
Contributor Author

Rebasing after oras-project/oras-py#168

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@isinyaaa isinyaaa force-pushed the push-xpzxprvquopn branch 2 times, most recently from 6d110c5 to cfa70d4 Compare November 14, 2024 13:14
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants