Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on 500 #168

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Retry on 500 #168

merged 3 commits into from
Nov 13, 2024

Conversation

isinyaaa
Copy link
Contributor

This is the standard policy in the upstream oras-project/oras-go. It actually fixes an issue when uploading manifests to Quay.io, as can be observed in this HTTP traffic capture from WireShark:

image

Tested with a local instance and also with Quay.io successfully following https://github.com/isinyaaa/quay-demo.git
Remote upload https://quay.io/repository/idoamara/testrepo verified with oras cp quay.io/idoamara/testrepo:v1 --to-oci-layout testrepo-mirror

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Copy link
Contributor

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! And makes sense. Could you please bump the version in version.py and add a corresponding note to the CHANGELOG.md about the changes?

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@isinyaaa
Copy link
Contributor Author

isinyaaa commented Nov 13, 2024

For the record it seems that Quay manifest push is failing due to a missing property on the manifest
We're working on a fix for oras.

@isinyaaa isinyaaa requested a review from vsoch November 13, 2024 17:57
@vsoch vsoch merged commit 71599b9 into oras-project:main Nov 13, 2024
5 checks passed
@isinyaaa isinyaaa deleted the push-okxkztvwokrv branch November 13, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants