Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podman doesn’t support CSV escaping in --mount arguments #13922

Closed
DemiMarie opened this issue Apr 19, 2022 · 4 comments · Fixed by #13969
Closed

Podman doesn’t support CSV escaping in --mount arguments #13922

DemiMarie opened this issue Apr 19, 2022 · 4 comments · Fixed by #13969
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@DemiMarie
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Steps to reproduce the issue:

  1. See that Docker documents that arguments to --mount use CSV syntax.

  2. Try to CSV-escape an argument to --mount that contains commas

Describe the results you received:
Does not work

Describe the results you expected:
Works

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

Version:      3.4.4
API Version:  3.4.4
Go Version:   go1.16.8
Built:        Wed Dec  8 16:45:07 2021
OS/Arch:      linux/amd64

Output of podman info --debug:

Not applicable as this is a command line parsing problem.

Package info (e.g. output of rpm -q podman or apt list podman):

podman-3.4.4-1.fc35.x86_64

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)

No

Additional environment details (AWS, VirtualBox, physical, etc.):
Fedora 35 Qubes OS VM

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 19, 2022
@mheon
Copy link
Member

mheon commented Apr 20, 2022

Can you provide an example command that should work, but does not?

@DemiMarie
Copy link
Author

podman run '--mount=type=tmpfs,tmpfs-size=512M,"destination=/run,"' --interactive --rm -- registry.access.redhat.com/ubi8/ubi:latest sh

Podman complains that "destination is an invalid mount option. Since such commands currently do not work at all in Podman, fixing them should not cause backwards compatibility problems.

@rhatdan
Copy link
Member

rhatdan commented Apr 20, 2022

encoding/csv should be used to look at the mount type.
@flouthoc PTAL

@flouthoc
Copy link
Collaborator

Thanks above PR should close this.

flouthoc added a commit to flouthoc/podman that referenced this issue Apr 22, 2022
…omma

Following commit ensures that csv escaping is supported while using
inline `--mount=type=......` flag with `podman run` by using
`encoding/csv` to parse options instead of performing a `split.String(`
by `comma`.

Closes: containers#13922

Signed-off-by: Aditya R <arajan@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants