specgen-volumes: parse --mount using csv-reader instead of split.
#13969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
flouthoc
changed the title
--mount using csv-reader instead of split.
flouthoc
force-pushed
the
mount-csv-parsing
branch
from
f77dc81 to
9f1bb7f
Compare
Luap99
reviewed
Apr 22, 2022
| } | ||
| if len(records) <= 0 { | ||
| return "", []string{}, errInvalidSyntax | ||
| } |
There was a problem hiding this comment.
should we error for len(records) > 1 as well, this will happen if the argument contains a newline?
There was a problem hiding this comment.
I think we should, made this len(record) != 1
…omma Following commit ensures that csv escaping is supported while using inline `--mount=type=......` flag with `podman run` by using `encoding/csv` to parse options instead of performing a `split.String(` by `comma`. Closes: containers#13922 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
mount-csv-parsing
branch
from
9f1bb7f to
f87f23e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Thanks! |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following commit ensures that csv escaping is supported while using
inline
--mount=type=......flag withpodman runby usingencoding/csvto parse options instead of performing asplit.String(by
comma.Closes: #13922