-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play kube support for volumes created with podman volume create
#5788
Comments
This currently does not work? What happens? |
We have support for bind-mount (and I think tmpfs) volumes, but not named volumes. Those generate additional bits of Kubernetes YAML, which we have to deal with in both |
I can look into this. |
A friendly reminder that this issue had no activity for 30 days. |
@kunalkushwaha Any progress on this? |
@mheon @haircommander Any ideas on this? |
On our end, the real difficulty is figuring out the format for Kube volume YAML. Once we have that, I think it's a pretty simple mapping. |
named volumes sound like emptyDir. am I correct in saying so? |
Hmm. That does sound pretty close. I'll take a look. |
@haircommander That seems fine to me too, since podman runs on the host. |
@ryanchpowell Could you work with @haircommander on this? |
@mheon @ashley-cui Could you take a look? |
The problem with emptyDir is that its lifetime is the same as the pod. When the pod is created, a new empty volume is created. When the pod is destroyed, the volume is deleted forever. emptyDir is a scratch space for running applications. It's similar to podman volumes are independent of pods; they can be created and destroyed on their own. This is more similar to Kubernetes PersistentVolumeClaims, which is an API designed for abstracting over vendor-specific storage like S3 or Google Cloud Storage. |
I opened a PR to support this. I am trying to figure out how to write unit tests for this. Any guidance would be appreciated. I'm a bit stuck trying to figure out how to mock the Runtime. |
Using named volume in kube files is already possible, just use a
|
If that works, I'd consider it more of a bug than a feature... I'm not saying we'll fix it, but if it breaks, fixing it will not be a priority. |
#8497 merged and added support for persistent volume claims (backed by named volumes) to |
@mheon I can we can close this issue now. Kudos for implementing the fixes 👍 ❤️ Sorry for not being around. |
A friendly reminder that this issue had no activity for 30 days. |
@mheon this is probably something you need to do. |
Unassigning myself, I don't think I'm going to have time for this any time soon. Hopefully the New First Issue label will attract contributors? |
A friendly reminder that this issue had no activity for 30 days. |
@umohnani8 PTAL |
I just a came across a situation where having the generate behavior would be helpful. |
This has been on my to do list for a long time, and it just worked its way up to the top. @jwillikers, please go ahead and work on this, it would save me some work! But I'll probably get to it next week if no one is working on it at that time. |
Fixes containers#5788 This commit adds support for named volumes in podman-generate-kube. Named volumes are output in the YAML as PersistentVolumeClaims. To avoid naming conflicts, the volume name is suffixed with "-pvc". This commit adds a corresponding suffix for host path mounts. Host path volumes are suffixed with "-host". Signed-off-by: Jordan Williams <jordan@jwillikers.com>
Fixes containers#5788 This commit adds support for named volumes in podman-generate-kube. Named volumes are output in the YAML as PersistentVolumeClaims. To avoid naming conflicts, the volume name is suffixed with "-pvc". This commit adds a corresponding suffix for host path mounts. Host path volumes are suffixed with "-host". Signed-off-by: Jordan Williams <jordan@jwillikers.com>
Fixes containers#5788 This commit adds support for named volumes in podman-generate-kube. Named volumes are output in the YAML as PersistentVolumeClaims. To avoid naming conflicts, the volume name is suffixed with "-pvc". This commit adds a corresponding suffix for host path mounts. Host path volumes are suffixed with "-host". Signed-off-by: Jordan Williams <jordan@jwillikers.com>
Play kube support for volumes created with
podman volume create
/kind feature
Description
Play kube support for volumes created with
podman volume create
The text was updated successfully, but these errors were encountered: