Add support for play/generate kube PersistentVolumeClaims and Podman volumes #9935
Conversation
|
@EduardoVega looks like you've some trailing space issues. |
EduardoVega
force-pushed
the
5788-kube-volume
branch
5 times, most recently
from
6e14a90
to
854679d
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EduardoVega, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
pkg/domain/infra/abi/play.go
Outdated
| // attributes, so they can be configured using annotations since they will not affect k8s. | ||
| for k, v := range pvcYAML.GetAnnotations() { | ||
| switch k { | ||
| case "podman.volume/driver": |
There was a problem hiding this comment.
2 questions for consideration:
- should these be kept as constants anywhere?
- often, these special annotations follow the format of a url:
io.podman.volumedoes it make sense to apply that here?
There was a problem hiding this comment.
- Let me change that.
- You're correct. The url format does not provide any special functionality but it is better to stick to the k8s syntax. What about something like this
volume.podman.io/driverbased onnode.kubernetes.io/instance-type?
There was a problem hiding this comment.
This has been changed.
|
A couple of questions but none of them blocking. This looks great @EduardoVega, I especially like the idea about using annotations to get special podman options |
Signed-off-by: Eduardo Vega <edvegavalerio@gmail.com>
EduardoVega
force-pushed
the
5788-kube-volume
branch
from
854679d
to
61cb6d6
Compare
|
/lgtm |
|
Thanks @EduardoVega |
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: Eduardo Vega edvegavalerio@gmail.com
This PR provides the ability to support Kubernetes PersistentVolumeClaims for podman play or generate kube. A k8s PersistentVolumeClaim represents a Podman volume, only the PVC name is required to create the volume. Podman volume options can be set using PVC annotations.
This is based on this PR #8266 and related to this Issue #5788.