Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-remote build: -v is a NOP #9874

Closed
edsantiago opened this issue Mar 29, 2021 · 5 comments · Fixed by #9882
Closed

podman-remote build: -v is a NOP #9874

edsantiago opened this issue Mar 29, 2021 · 5 comments · Fixed by #9882
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue

Comments

@edsantiago
Copy link
Member

It does check for invalid path:

$ ../bin/podman-remote build -v /foo:/bar .
Error: error checking path "/foo": stat /foo: no such file or directory

...but apart from that, it seems to be a NOP. Rather than fill out a detailed issue with a custom-crafted Containerfile and logs, I'm going to take a step back and ask: what does -v mean in the context of podman-remote, anyway? I'm tempted to think it should be intercepted with a fatal you-seem-to-be-unclear-on-the-concept error.

@edsantiago edsantiago added kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Mar 29, 2021
@rhatdan
Copy link
Member

rhatdan commented Mar 30, 2021

Well it should be hidden.

@rhatdan rhatdan self-assigned this Mar 30, 2021
rhatdan added a commit to rhatdan/podman that referenced this issue Mar 30, 2021
[NO TESTS NEEDED] This PR is mainly documentation and some code cleanup.

Also cleanup and consolidate handling of other hanlding of podman-remote
hidden options.

Fixes: containers#9874

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@edsantiago
Copy link
Member Author

I guess I should've included a setup:

$ cat Containerfile
FROM alpine
RUN mount | grep foo
$ mkdir /tmp/mymount
$ echo hi >/tmp/mymount/myfile
$ ../bin/podman-remote build -t foo -v /tmp/mymount:/foo .
STEP 1: FROM alpine
STEP 2: RUN mount | grep foo
Error: error building at STEP "RUN mount | grep foo": error while running runtime: exit status 1

With non-remote:

$ ../bin/podman build -t foo -v /tmp/mymount:/foo .
STEP 1: FROM alpine
STEP 2: RUN mount | grep foo
tmpfs on /foo type tmpfs (rw,seclabel,nosuid,nodev,nr_inodes=409600,inode64)
--> 5a6d0524e3c
STEP 3: RUN cat /foo/myfile
hi
STEP 4: COMMIT foo
--> 8131cb095fb
8131cb095fb56f67408e5b4e75083f07f740f9ac4554b25fdc87201a5aea2915

The way I read @Luap99's comments in #9882, I believe he's saying that -v /fs:/fs should work. It does not. Reopening.

@edsantiago edsantiago reopened this Mar 30, 2021
@Luap99
Copy link
Member

Luap99 commented Mar 30, 2021

Yes it should work but I only tested with podman create/run and never podman build.

mheon pushed a commit to mheon/libpod that referenced this issue Apr 16, 2021
[NO TESTS NEEDED] This PR is mainly documentation and some code cleanup.

Also cleanup and consolidate handling of other hanlding of podman-remote
hidden options.

Fixes: containers#9874

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
jmguzik pushed a commit to jmguzik/podman that referenced this issue Apr 26, 2021
[NO TESTS NEEDED] This PR is mainly documentation and some code cleanup.

Also cleanup and consolidate handling of other hanlding of podman-remote
hidden options.

Fixes: containers#9874

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented May 3, 2021

This is now documented.

@rhatdan rhatdan closed this as completed May 3, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants