Document --volume from podman-remote run/create client

[rhatdan]

[NO TESTS NEEDED] This PR is mainly documentation and some code cleanup.

Also cleanup and consolidate handling of other hanlding of podman-remote
hidden options.

Fixes: #9874

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

This is not correct. podman-remote run --volume is supported and should work. It will just not mount the host path on the client instead it will always mount the host path on the server. This should be documented but do not hide --volume from remote.

[rhatdan]

Why would we want to support this?

[rhatdan]

podman-remote main use case in on Macs and Windows, and remote machines, I don't see this as a common behaviour and set's bad expectations.

[Luap99]

Well first there are users who use this, see #8473. Second, how do you provide persistent storage for your containers when you disable the --volume flag. (I know you just hide them, but still documenting that this doesn't work is wrong.)

[edsantiago]

--volume is kind of special in that it can also refer to named volumes, which (I think?) should be able to work with podman-remote (confirmed: podman-remote volume xxx seems to work). I agree with @Luap99 that the flag shouldn't be marked hidden, but I tentatively disagree about path mounts: I don't think -v /fs:/fs is meaningful in the remote case. (BUt I'm listening, and could be convinced otherwise)

[Luap99]

-v /path:/path is needed for remote. You can have only one storage location with named volumes. When your container needs data from different partitions you cannot use named volumes, also you might want to mount files from the host into the container.
Docker works exactly the same.
The --volume is without a doubt one of the most used flags for run/create. Hiding or removing it will confuse users even more and saying it is not supported is just wrong.

[rhatdan]

Beaten into submission.

[rhatdan]

I changed the podman-remote help to reflect this information as well.

./bin/podman-remote run --help | grep -- -v,
-v, --volume stringArray Bind mount a volume into the container. Volume src will be on the server machine, not the client

[TomSweeneyRedHat]

LGTM

[Luap99]

/lgtm
/hold

[rhatdan]

/hold cancel