Add support for PidsLimit in quadlet #19955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
rhatdan
added a commit
to rhatdan/qm
that referenced
this pull request
Sep 12, 2023
The default limit on number of processes within the container is 1024. This is far too low for QM. Selecting 10000 seems like a better number but really this needs to be set by the final distributor of the OS. Requires containers/podman#19955 to be in Podman. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| ### `PidsLimit=` | ||
|
|
||
| Tune the container's pids limit. | ||
| This is equivalent to the Podman `--pids-limit` option |
There was a problem hiding this comment.
Suggested change
| This is equivalent to the Podman `--pids-limit` option | |
| This is equivalent to the Podman `--pids-limit` option. |
ygalblum
reviewed
Sep 13, 2023
pkg/systemd/quadlet/quadlet.go
Outdated
Comment on lines
454
to
457
| pidsLimit, _ := container.Lookup(ContainerGroup, KeyPidsLimit) | ||
| if len(pidsLimit) > 0 { | ||
| podman.add("--pids-limit", pidsLimit) | ||
| } |
There was a problem hiding this comment.
Suggested change
| pidsLimit, _ := container.Lookup(ContainerGroup, KeyPidsLimit) | |
| if len(pidsLimit) > 0 { | |
| podman.add("--pids-limit", pidsLimit) | |
| } | |
| pidsLimit, ok := container.Lookup(ContainerGroup, KeyPidsLimit) | |
| if ok && len(pidsLimit) > 0 { | |
| podman.add("--pids-limit", pidsLimit) | |
| } |
QM needs to be able to specify the maximum number of PIDs within the QM environment to ensure FFI. Picking a total of 10,000 Pids might be a rasonable constraint on the QM. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, Yarboa, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QM needs to be able to specify the maximum number of PIDs within the QM environment to ensure FFI.
Picking a total of 10,000 Pids might be a rasonable constraint on the QM.
Does this PR introduce a user-facing change?