Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] limit the number of processes inside of the QM #206

Closed
wants to merge 1 commit into from
Closed

[WIP] limit the number of processes inside of the QM #206

wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 12, 2023

The default limit on number of processes within the container is 1024. This is far too low for QM. Selecting 10000 seems like a better number but really this needs to be set by the final distributor of the OS.

Requires containers/podman#19955 to be in Podman.

@rhatdan
limit the number of processes inside of the QM
09c0720 
The default limit on number of processes within the container is 1024.
This is far too low for QM. Selecting 10000 seems like a better number
but really this needs to be set by the final distributor of the OS.

Requires containers/podman#19955 to be in
Podman.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Yarboa
Yarboa approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member Author

rhatdan commented Sep 12, 2023

This needs to be revisited with podman 4.7 is released.

@dougsland
Copy link
Collaborator

This needs to be revisited with podman 4.7 is released.

@rhatdan should we also add a requirements in the rpm ?
/cc @lsm5

@dougsland
Copy link
Collaborator

LGTM anyway

@dougsland
Copy link
Collaborator

btw, I faced similar issue already in the E2E when stressing the system with increase of the number of nodes:

    --number-of-nodes)
      NUMBER_OF_NODES="${2}"

      # avoid "too many files opened"
      sysctl fs.inotify.max_user_instances=$((${2}*100)) 1> /dev/null

The code is here:

qm/tests/e2e/run-test-e2e

Lines 146 to 147 in 1e7bf2a

# avoid "too many files opened"
sysctl fs.inotify.max_user_instances=$((${2}*100)) 1> /dev/null

@rhatdan
Copy link
Member Author

rhatdan commented Sep 12, 2023

Changed to use Ssytemd mechanism, so closing this for now.

@rhatdan rhatdan closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yarboa Yarboa Yarboa approved these changes

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

@dougsland dougsland Awaiting requested review from dougsland dougsland is a code owner

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhatdan @dougsland @Yarboa